From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: paper over missed irq issues with force wake vodoo Date: Fri, 06 Jan 2012 12:56:20 -0800 Message-ID: <86vcooturv.fsf@sumi.keithp.com> References: <1325695930-2524-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1202222507==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id B8E5E9E972 for ; Fri, 6 Jan 2012 12:56:25 -0800 (PST) In-Reply-To: <1325695930-2524-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx Cc: Daniel Vetter , stable@kernel.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org --===============1202222507== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 4 Jan 2012 17:52:10 +0100, Daniel Vetter = wrote: > Two things seem to do the trick on my ivb machine here: > - prevent the gt from powering down while waiting for seqno > notification interrupts by grabbing the force_wake in get_irq (and > dropping it in put_irq again). > - ordering writes from the ring's CS by reading a CS register, ACTHD > seems to work. >=20 > Only the blt&bsd ring on ivb seem to be massively affected by this, > but for paranoia do this dance also on the render ring and on snb > (i.e. all gpus with forcewake). >=20 > Tested with Eric's glCopyPixels loop which without this patch scores a > missed irq every few seconds. >=20 > This patch needs my forcewake rework to use a spinlock instead of > dev->struct_mutex. I've pushed these to the forcewake-spinlock branch in both my fdo and kernel repositories. Please give that a try on IVB and SNB to make sure things are working right. I'd like to get these into master as well as being sent off to stable@ for 3.2.x =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTwdf9DYtFsjWk68qAQiyFg/+PkXYLzo83p+dTowAG3w16QXeQ27nbLGS joYyjccZs0b+oj4aAKwR31qVdN9idcN6bnLschyh+8VWgb927ujm7s2FuiOlyFT7 tjyPAuHm5KSA77n456o0q0/N2XsN+Dj9o6+5fz7mTuMBYRs9m4HmlKd330k5hPDw I9+9/gcB+0LJuhDd74PNcZ6+zMxIhegv0uNZ/yAjS/hjfHdoFa+L+vtf2InVV2md 5yWmf6utQe0McfJbtV3tgHXk8Za3cc9jbqnLFn5NUwhQHxGZ2Xq09AA/iiN+S1d8 1Rmbqg0daHPGK8+ybpDnIIt4spTPfanGPCdMw0ar4c+1exSynJXmJbn+mLN4+350 YKeikH59kcPZ3WIAlRCXrFC4jSh3Aq/x41sqLFRrfcc/K8nJcX7hFtcikxRQHgkR I10HO12TZBtuH7s+z/2Qd0HPO4yJO9V0UsgNMjwFfO1h/gAwLlcC+Png6s4kabKm OsSEr0HmDcnY+HjOsbKFE9kkygQH+pqrOSxdlyFGFv0UG+2S+upjd0fhqPs7dHpq 6owKtvXfjhHc6azDN8vzHoy1QsPRpFZvmcGhbkLVrOknlXh6AXL3V9qnlxuQ9xXN cF4UGYAXtl66m8ExbbfdrntsJ+PRi6gzH88BUeitglgN/y3YzfmL0z35yzTlfwhQ CZ7tIfvBJdE= =zchx -----END PGP SIGNATURE----- --=-=-=-- --===============1202222507== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1202222507==--