From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C244E12882C for ; Tue, 16 Apr 2024 13:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713274395; cv=none; b=GncwBiqyrYaEiHsv2/rGPGMG23yKG1GrZn0RPyqjoGDBWmNy0BtZPMTvSK8lqisFzMYgTtoHprK3QMLx4BKYsiKAlzegsSIdMgM5zHDDVFt5d9QiPD5ZypZlHE1dkVfeXaHzTB1N0RF2DWaf40eCrju8OdeFpnE1ljj0psY/Bkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713274395; c=relaxed/simple; bh=j6bp9ZOH43dO4u5P8+AHfLwMhLEnNfpO+fPgnH5LRwk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=MNGc1L/dPVf4n8IoXFDpMEZTz5/hWSEakaKYbT2HPmU7ewye7CjiQV94z/YXu2F6C9ZOJrMH/77juHkM/tkyXnXFLdwT+XBanC2jo8gX4ZNCby12kn8iy7H6rGQGRsIdsieCdb9c6mJzAtRlR66VlMvvd72KdI4cQLvHjOZTusk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WV70iSSV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WV70iSSV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52FB0C113CE; Tue, 16 Apr 2024 13:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713274395; bh=j6bp9ZOH43dO4u5P8+AHfLwMhLEnNfpO+fPgnH5LRwk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WV70iSSV3lPb7cXUUJd+PIPGdwWDJpqc7Gb74gDPvxDnapYbkRXeXqfZ2t0O5jxZp ryGMCkunkUhgG6tyfc7IHBAGROuufBdT+ZAmYv9xIGD6PWVZP/SlhEusO6mk+iAuVA 9czTBn8KyiyHxEd2s1Btqhms2akdF/uAzUtNRHa+Vnl81iOHZOdhGJxBLqcfD4zQnc CF3Go3eodSwJT2OrHJPNp4Yz+wpKsNoU5SBmFI17Vbtt1c4VwQogGbZw5vsRrZdjpJ ARj4Ldv6SkHFVLjmQ65rHRP7VRJqYIBTEGX9MWIGWb6mZaQXTL4qyDKA4Qigh/M+vT WiH6PbZEmMerQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rwivx-00526E-2l; Tue, 16 Apr 2024 14:33:13 +0100 Date: Tue, 16 Apr 2024 14:33:12 +0100 Message-ID: <86wmoxqvon.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Fuad Tabba , kvmarm@lists.linux.dev, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, smostafa@google.com Subject: Re: [PATCH v2 47/47] KVM: arm64: Refactor checks for FP state ownership In-Reply-To: References: <20240416095638.3620345-1-tabba@google.com> <20240416095638.3620345-48-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, tabba@google.com, kvmarm@lists.linux.dev, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, smostafa@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 16 Apr 2024 11:55:24 +0100, Mark Brown wrote: > > [1 ] > On Tue, Apr 16, 2024 at 10:56:38AM +0100, Fuad Tabba wrote: > > To check for fpsimd state ownership, use the helpers > > host_owns_fp_regs() and guest_owns_fp_regs() instead of directly > > using the enums. > > Reviewed-by: Mark Brown > > It does occur to me that there's probably enough FP changes in this > series to warrant a separate series, there didn't look to be much > overlap, they look good and as you say in the cover letter this is a > rather large grab bag so splitting out should make things a bit more > digestable. I'm already tracking this series as a whole, and splitting FP off the main series will only make it harder to track. Plus, patch #1 really shows that there is a need to look at this code globally, and not with the narrow angle of the FP stuff. M. -- Without deviation from the norm, progress is not possible.