From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96C8DC433EF for ; Wed, 22 Dec 2021 16:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QVZKUcYfdQIUpbrdeSCLjyQLB2shv1pKx4fAinzyF8c=; b=Yn7ak3RIhxoIUI qAWhH4HBevRk59JNVLTCRn2ukhBAeA55a0D7Wx/yaikRANLBE0US6jCtKFoSKbBNZxYGzjln4AWDM 9OHCMjHxlp4NJkGhKREbvugeKvXm3RlpredU8b7A6gpoE5BcZt9WrHUmcfhGOJWr4I0pLiN92TR7D XfWOKsQMYG/n0iWGXYjMGqTEvrQ850JG6xJNKiqaeo6K2UflgMGR3RknL1W9skkCc1EbPfrH947Re nGS0gDT6eyksgcmRuJYUr/sJ8gTo8YkPf/MpC8i1ikVVrwHzqJLAjo1Ge6McTrDZ4IQJIt22WLDEn IWE8onSp5/c0EPB4IN2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n04EI-00AqFJ-SH; Wed, 22 Dec 2021 16:12:39 +0000 Received: from mail-bn8nam11on2123.outbound.protection.outlook.com ([40.107.236.123] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n04EF-00AqES-04 for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 16:12:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nj/IjRqPkvpXKZuhJcOon//DDL3AOws+IY85XkkXIu05936lRjhUkkzL3GQ4YMaAum+2/KF+0iL/QPMxJwZxAq2ZjuMuPeOxROlIbDSHHf/5YgCRvKGnU66qSvNK+ToelYSv3KcHwArdzUSa8TOiJMFaeS+C03sPyk0D9pCqlzg2yH/4JHrIhi8u/8j6L1nnw2vivj7K+FxEwJCW5cUnkA++K06rPc8y/zceE4m3F8dovEbOHrwfQxEvfbgqNEAGfwl5tXlo/77P/dmiPASiZWMWxmRIk5lliLaHoJK0N+kTf+NhOe8r4nA9LTZgoUTNebixZ/0oXu1dti69UMFivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oy79jpMYMAXOhbFVEpfr88hXv7NGLVqKLWi0S2GSjaQ=; b=j8gZUM/hAoANkK3zx5zwU1SeyDJo7tzKDT2ndYDwAm1GtqiJBTDXGjTh/m34iQMtdTlWR9oHLz1dw6gOMOOJ29RJ+UVk7keg2TZJzL3TSZBbbKpBz1JXQOTJedZOeJhECSP8bqLgyKLRfHDVbY3p43xzQ5i4Aq3wBzpHqeyshSTgyE4N+PSwGuJqIgMhIhargJ/iVyz9LQeo/7Bd7XpCjy6gm/6uMAEKsbi7Ez2HfOG+I8yxxCkf60jeGueJ95whqRvigOOcpfk2UzhYc3BFVTVZPJkfHrpcyxmusHP2s3mTQIDEf+2zlQFdcfPDkDLrnpwlOr3fnWMQr6mjZPsmig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oy79jpMYMAXOhbFVEpfr88hXv7NGLVqKLWi0S2GSjaQ=; b=cQsziDjRVli5DvHTzQ9kh2DSfFndC/AsI3QLmV6WZfYQlgz08CUcJq5/BuppUQMFRJiNJ1BVecuNVxgAXKJmRLJo/ajv9vXUG95WbX1YQYi+uUAcpb7LVSjPNJYU0OcaS0FRL76kgVL0OjHwMvhv1DX6BERJKNOZ8kB9iQ3BSso= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from MWHPR0101MB2893.prod.exchangelabs.com (2603:10b6:301:33::25) by CO6PR01MB7513.prod.exchangelabs.com (2603:10b6:303:144::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.14; Wed, 22 Dec 2021 16:12:30 +0000 Received: from MWHPR0101MB2893.prod.exchangelabs.com ([fe80::526:8374:e93f:3648]) by MWHPR0101MB2893.prod.exchangelabs.com ([fe80::526:8374:e93f:3648%4]) with mapi id 15.20.4801.020; Wed, 22 Dec 2021 16:12:29 +0000 From: D Scott Phillips To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Will Deacon , Darren Hart , patches@amperecomputing.com Subject: Re: [PATCH v5] arm64: errata: Fix exec handling in erratum 1418040 workaround In-Reply-To: References: <20211220234114.3926-1-scott@os.amperecomputing.com> Date: Wed, 22 Dec 2021 08:12:27 -0800 Message-ID: <86wnjwfwk4.fsf@scott-ph-mail.amperecomputing.com> X-ClientProxiedBy: CY5PR04CA0015.namprd04.prod.outlook.com (2603:10b6:930:1e::9) To MWHPR0101MB2893.prod.exchangelabs.com (2603:10b6:301:33::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11c81c8b-8769-464d-77c6-08d9c565da3a X-MS-TrafficTypeDiagnostic: CO6PR01MB7513:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yE1omplPxJz8Cc93d0j4me/m23vP2Kes4iZyvvTQ4ibPOaHrKa5phaBUMD+RmVv8xKWSEJEPtD0eM0/6juWvIbgRhrMZLX3M2SEFOR3XjLgiCVfkH1oM4rDbkjeNwn/9N6ZbgbFG1zEeDWIUcllgxQ4L2DIynckLkP6p3GGGMLyoUwJJFeg9pjapjw/7TgqE7tZqPdWDOAEeGMmiCBmPrKXhBXtQcGrLNlIPeqRs/68ZPaE/mVLWWT+kDvjcW5WTV7jD6bUc4qtV3UwWhexMqntokNUkZvKEduZHY9OjHkOfdMjtE9KJR+nORue/uHJuOtNG0UP/hAJr9JFMG3//v4i1oYfxG2HXWuRvchjtUGcACKi9LHkGwA5JSorDhHPYPEXFEqvH5q++nTiMTz38tjQK/v4Uxx7S056SzcNVjwNI2EA6cbBcBLZjyldj441Lzy16SGzLQiSifj2w0+bs06hcdhuA3kPXoTGXCdeM4ZWsgUBX4/ZIzxZNmEaQ+mZral0o7v1SFco/IjGwptA/olWrKXlGdPneziqaXN1gRg1Z1J5vQL7GGycRR1ZwmT2X9WaRP0Mzb3CKfP6KKOVSMhbiG2RUTsB6Mo330Q2TQweoiC2bbVCcnokAsltWM/5i/1/gey/z0sblPlb+MagT59VDHbhjttiZuNjaLr/de84k9f9M+hkFZRmYvUJnjruskbP0lZbir7qzNTMaM0zIRw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR0101MB2893.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6486002)(52116002)(86362001)(6506007)(54906003)(5660300002)(8676002)(186003)(316002)(6512007)(2906002)(4326008)(66946007)(66476007)(107886003)(26005)(83380400001)(6916009)(38350700002)(508600001)(38100700002)(66556008)(8936002)(9686003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dXMrWG4qZ0QE6jywee422y3zAxdFKLfMeHkR3Irytd3BsTy3kCJHavBBdhQQ?= =?us-ascii?Q?605f07Da400I76CxtCwHSYhAjuXIbEbsSGtoU4b95slj9b2LUeWnyqE2cyTU?= =?us-ascii?Q?oRAqnmg9pXRArqfBH/yDZtNc+IBp9ES1mfwex9Kq2131u0ONxedPFNS8SM+p?= =?us-ascii?Q?jINKyL9CEqd/YLh0J3FcwCPIOuPo4T0FD2PMj17V0Irjtv8grXoNpWCjUUu+?= =?us-ascii?Q?PGRJQNbsR9DH9VTjWXH2AUPH+hwlP8IxqAKzQqgORm5j/TUfI0a0kfs63d/D?= =?us-ascii?Q?vemYooTQOnDaURu2o5Jp1w0+dCL9msciT3xn7WOuZfjsUk1QzxJ/4pbq6PaJ?= =?us-ascii?Q?1gPNVKJOtSraO7bGyoaamfxATl4iboWRRJ9e1M/irNGP/OXamgSpj8SH6hah?= =?us-ascii?Q?bGB/J8DSg+LH/A7PWs6ZmDNrhCymIc0nuLItswWuC40qOtz7RKskl+9nLkW/?= =?us-ascii?Q?UltD1bmNK1JZEGQMmgrOfp1bYYK5WJgXTMbm1TemI6NhJ6W8TBuVENf186aK?= =?us-ascii?Q?hkBVZev8/u/qDxxAUadV9SB06soS46YukIBw6tvvuNdAi3+09mjyibfae4Uo?= =?us-ascii?Q?QNKXgJV7RnSm6PcO0GDzHROT+8uPMNNzGtvgzZ2nj/L6ueY9ZgQK/TLT+POc?= =?us-ascii?Q?Sguq5r1tu6mIO8WOkhsLqrmOMwYpenAVfi/asDpCEEM/sgkrh3h8qDg1cTUS?= =?us-ascii?Q?0CFNb+rFIWcjkFT6YwupoM9NNTNKcI1++x+PibF0ZkJpyM0x325d/bi1IwXD?= =?us-ascii?Q?BDUylcl+UBKLCZZM43yhYtXVYgEiFQKaRKwHgwAtpNyV3g0gEYDKlyv1Hhoz?= =?us-ascii?Q?pnE7F4iz2jvAB4wgvdlzmlKrRO6g3S85fAMr3zldnjslnqyX6r/SG+W1qmmy?= =?us-ascii?Q?niSRNFNqRUcYcvSuEhBLhcGO9iApupSjlgFRhSB69kVi3vhxtsxDhNAh3n22?= =?us-ascii?Q?Ze6JUPDKkFBgC/k4C3xwNgMrE+jtDWls5xPT5TIXE5O1WPqDeJBGNibx8Ldb?= =?us-ascii?Q?Bw8WVJ6UKmuHVHiCrnyLIJVimPulv42P3D3feN9lg8kbolq6XJXrFh2TqQpy?= =?us-ascii?Q?cnnGg+sqWqVh8j17kFRZTAcPU9SMXdBtmeIQP2pErg3oIj9VRBVwfKCvDuLo?= =?us-ascii?Q?YBKQwzYPmCYVVJF8xmUpku2ruQL7wh4mkZXYiUoRhf7eV47aiFs7l+cZKqG0?= =?us-ascii?Q?zrngIfT6S99tRJdv1acpQB9Z+s9kYgm2a3trqX5g6QK/GZAvWSME8V7NKKmp?= =?us-ascii?Q?kEc+GrluXmyXmTJcWBUUOk4nvCaegY9C4P3p74LCAqj/3IkuRdK6Yiur4am9?= =?us-ascii?Q?q5bacmtjYLQ9YQcubCpFPQEvu5RdNauq1Klvaz0rBiaWgE+P4thLL6uKsr7W?= =?us-ascii?Q?wASq+VX7bE/ECWSj4Tlpol0fmDf5tRJ3FtdBKNO9huh7U7ooA6aW5UE6obdp?= =?us-ascii?Q?euDkPuF8y/w51niyYwyfi6M//kNQwGrDldOe3dza5L2+fPog6IW7FaGg6Xi+?= =?us-ascii?Q?Kug+rsyFZXdg0yaZq+PujFNmbdYlXOoA5cRPa0VaEoQLTSEwY0ZoxWSYUvU/?= =?us-ascii?Q?jouqlltuBYKIY7wruOWa+YYEu91CCwx85rnWyyp9sIWFEkFAh3HqMOITPNQ3?= =?us-ascii?Q?haESk+ChRzy+poe0WxATNybf1uljzzbUaP7n/FqIBzZVRhvyhBAflRcD6vRE?= =?us-ascii?Q?0uvozxpe0hX+7WnkntMjEv12/b/robGbdxtHtXohPCapAVDdpzd8r5hRHCDj?= =?us-ascii?Q?Dkd9gGbnVg=3D=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11c81c8b-8769-464d-77c6-08d9c565da3a X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2893.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 16:12:29.7175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8RZOh62LBQJc0xDcnsqQmvAHI3f9S/r7s02lsr2XPUa/7MXaREHZJgvDlG05uflP1fss/k1PIdPTGzGbosn2jJ/XvTwonJc/VzaJYRB8iTbLjmRSIFuouqSHgGSW3Wig X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR01MB7513 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_081235_149129_3ECDB61D X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Catalin Marinas writes: > On Mon, Dec 20, 2021 at 03:41:14PM -0800, D Scott Phillips wrote: >> The erratum 1418040 workaround enables CNTVCT_EL1 access trapping in EL0 >> when executing compat threads. The workaround is applied when switching >> between tasks, but the need for the workaround could also change at an >> exec(), when a non-compat task execs a compat binary or vice versa. Apply >> the workaround in arch_setup_new_exec(). >> >> This leaves a small window of time between SET_PERSONALITY and >> arch_setup_new_exec where preemption could occur and confuse the old >> workaround logic that compares TIF_32BIT between prev and next. Instead, we >> can just read cntkctl to make sure it's in the state that the next task >> needs. I measured cntkctl read time to be about the same as a mov from a >> general-purpose register on N1. Update the workaround logic to examine the >> current value of cntkctl instead of the previous task's compat state. >> >> Fixes: d49f7d7376d0 ("arm64: Move handling of erratum 1418040 into C code") >> Signed-off-by: D Scott Phillips >> Cc: # 5.4.x > > Why 5.4? I think the fixed commit is 5.9. d49f7d7376d0 got backported into v5.4.62's 82b05f0838aa. That looks like that's the farthest it's made it back. Is this the correct way to handle fixing the backported change, or should a separate backport be sent to 5.4 for the fix? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel