From: Chris Ball <chris@printf.net>
To: Grant Grundler <grundler@chromium.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Nick Sanders <nsanders@chromium.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Doug Anderson <dianders@chromium.org>,
Chang-Eun Choi-SSI <cu.choi@ssi.samsung.com>
Subject: Re: [PATCH] mmc: sdhci: remove mdelay in eMMC tuning
Date: Wed, 14 May 2014 02:22:43 +0100 [thread overview]
Message-ID: <86wqdprw64.fsf@void.printf.net> (raw)
In-Reply-To: <CANEJEGt1-BYD2kaHJisQ=YBj6k4CJU5-7_bjW+M5TZ_yuMY_TQ@mail.gmail.com> (Grant Grundler's message of "Tue, 13 May 2014 18:13:30 -0700")
Hi,
On Wed, May 14 2014, Grant Grundler wrote:
>>> The delay is left in place for SD Cards, which use
>>> MMC_SEND_TUNING_BLOCK rather than MMC_SEND_TUNING_BLOCK_HS200.
>>> I'm not able to find evidence that this is required for SD in the
>>> specs I have access to, however this delay has been present from
>>> initial checkin for SD so I have preserved the original behavior for
>>> compatibility.
>>>
>>> This has been verified to fix observed glitching on local audio
>>> playback and recording on apps with inbuilt assumptions on storage
>>> latency.
>>>
>>> Signed-off-by: Nick Sanders <nsanders@chromium.org>
>>> Reviewed-by: Grant Grundler <grundler@chromium.org>
>>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>>
>> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Ulf,
> Is your ACK enough to get this to land upstream or does cjb need to
> respond it's been accepted?
>
> It doesn't appear to have landed in mmc-next branch yet:
> http://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/log/?h=mmc-next
>
> apologies if it appears I am being impatient...but it's been almost a week now.
Sorry about that. Looks fine, pushed to mmc-next with Ulf's ACK now.
- Chris.
--
Chris Ball <http://printf.net/>
next prev parent reply other threads:[~2014-05-14 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 1:52 [PATCH] mmc: sdhci: remove mdelay in eMMC tuning Nick Sanders
2014-05-07 8:35 ` Ulf Hansson
2014-05-07 22:01 ` Nick Sanders
2014-05-14 1:13 ` Grant Grundler
2014-05-14 1:22 ` Chris Ball [this message]
2014-05-14 12:18 ` Arnd Bergmann
2014-05-14 15:08 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wqdprw64.fsf@void.printf.net \
--to=chris@printf.net \
--cc=cu.choi@ssi.samsung.com \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nsanders@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.