From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua4ke-0002lx-58 for qemu-devel@nongnu.org; Wed, 08 May 2013 09:49:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua4ka-0007cW-3e for qemu-devel@nongnu.org; Wed, 08 May 2013 09:49:48 -0400 References: <1368019560-25218-1-git-send-email-agraf@suse.de> From: Torbjorn Granlund Sender: tg@gmplib.org Date: Wed, 08 May 2013 15:49:41 +0200 In-Reply-To: <1368019560-25218-1-git-send-email-agraf@suse.de> (Alexander Graf's message of "Wed\, 8 May 2013 15\:26\:00 +0200") Message-ID: <86wqr9lgy2.fsf@shell.gmplib.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] PPC: Depend behavior of cmp instructions only on instruction encoding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Richard Henderson Alexander Graf writes: Reported-by: Torbjorn Granlund Signed-off-by: Alexander Graf Ah, so my original patch was correct after all. Only the name of the author needed changing, apparently. :-) --- target-ppc/translate.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) =20=20 diff --git a/target-ppc/translate.c b/target-ppc/translate.c index a018616..89a4445 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -675,7 +675,7 @@ static inline void gen_set_Rc0(DisasContext *ctx, TCG= v reg) /* cmp */ static void gen_cmp(DisasContext *ctx) { - if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) { + if (!(ctx->opcode & 0x00200000)) { gen_op_cmp32(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)], 1, crfD(ctx->opcode)); } else { @@ -687,7 +687,7 @@ static void gen_cmp(DisasContext *ctx) /* cmpi */ static void gen_cmpi(DisasContext *ctx) { - if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) { + if (!(ctx->opcode & 0x00200000)) { gen_op_cmpi32(cpu_gpr[rA(ctx->opcode)], SIMM(ctx->opcode), 1, crfD(ctx->opcode)); } else { @@ -699,7 +699,7 @@ static void gen_cmpi(DisasContext *ctx) /* cmpl */ static void gen_cmpl(DisasContext *ctx) { - if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) { + if (!(ctx->opcode & 0x00200000)) { gen_op_cmp32(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)], 0, crfD(ctx->opcode)); } else { @@ -711,7 +711,7 @@ static void gen_cmpl(DisasContext *ctx) /* cmpli */ static void gen_cmpli(DisasContext *ctx) { - if (NARROW_MODE(ctx) || !(ctx->opcode & 0x00200000)) { + if (!(ctx->opcode & 0x00200000)) { gen_op_cmpi32(cpu_gpr[rA(ctx->opcode)], UIMM(ctx->opcode), 0, crfD(ctx->opcode)); } else { Hopefully my cmp speedup patch will be reposted under a new name and then included. --=20 Torbj=C3=B6rn