All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Chris Morgan <macromorgan@hotmail.com>,
	Yixun Lan <dlan@gentoo.org>, Thomas Gleixner <tglx@linutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH v1 1/1] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3588S
Date: Mon, 03 Jul 2023 19:42:27 +0100	[thread overview]
Message-ID: <86y1jwx2ek.wl-maz@kernel.org> (raw)
In-Reply-To: <20230703174233.wn7jusqeh3udusdz@mercury.elektranox.org>

On Mon, 03 Jul 2023 18:42:33 +0100,
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> 
> > > ---
> > >  drivers/irqchip/irq-gic-v3-its.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> > > index 1994541eaef8..034ece9ac47c 100644
> > > --- a/drivers/irqchip/irq-gic-v3-its.c
> > > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > > @@ -4727,7 +4727,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data)
> > >  {
> > >  	struct its_node *its = data;
> > >  
> > > -	if (!of_machine_is_compatible("rockchip,rk3588"))
> > > +	if (!of_machine_is_compatible("rockchip,rk3588") &&
> > > +	    !of_machine_is_compatible("rockchip,rk3588s"))
> > >  		return false;
> > >  
> > >  	its->flags |= ITS_FLAGS_FORCE_NON_SHAREABLE;
> > 
> > I don't mind taking this, but it also mean that only a new kernel
> > will boot.
> 
> Yes. My assumption is, that this is considered a fix and landing in the
> 6.5 cycle. The rk3588s.dtsi from v6.4 does not yet have the GIC ITS
> nodes. So there is not yet a tagged kernel with the boot failure. The
> first one will be v6.5-rc1.

Ah, fair enough. In this case I'll queue this patch without any remorse.

> The quirk in the GIC driver only landed in v6.4, so anything older
> is broken anyways. So effectively we are talking about v6.4 booting
> a v6.5 DT, which is not something we guarantee to be working as far
> as I know.

In general, I do make a point in making things work *in both
directions*. But given that this is an erratum, there isn't much we
can do, and advertising an ITS to a kernel that cannot handle it is
doomed.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Chris Morgan <macromorgan@hotmail.com>,
	Yixun Lan <dlan@gentoo.org>, Thomas Gleixner <tglx@linutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH v1 1/1] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3588S
Date: Mon, 03 Jul 2023 19:42:27 +0100	[thread overview]
Message-ID: <86y1jwx2ek.wl-maz@kernel.org> (raw)
In-Reply-To: <20230703174233.wn7jusqeh3udusdz@mercury.elektranox.org>

On Mon, 03 Jul 2023 18:42:33 +0100,
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> 
> > > ---
> > >  drivers/irqchip/irq-gic-v3-its.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> > > index 1994541eaef8..034ece9ac47c 100644
> > > --- a/drivers/irqchip/irq-gic-v3-its.c
> > > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > > @@ -4727,7 +4727,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data)
> > >  {
> > >  	struct its_node *its = data;
> > >  
> > > -	if (!of_machine_is_compatible("rockchip,rk3588"))
> > > +	if (!of_machine_is_compatible("rockchip,rk3588") &&
> > > +	    !of_machine_is_compatible("rockchip,rk3588s"))
> > >  		return false;
> > >  
> > >  	its->flags |= ITS_FLAGS_FORCE_NON_SHAREABLE;
> > 
> > I don't mind taking this, but it also mean that only a new kernel
> > will boot.
> 
> Yes. My assumption is, that this is considered a fix and landing in the
> 6.5 cycle. The rk3588s.dtsi from v6.4 does not yet have the GIC ITS
> nodes. So there is not yet a tagged kernel with the boot failure. The
> first one will be v6.5-rc1.

Ah, fair enough. In this case I'll queue this patch without any remorse.

> The quirk in the GIC driver only landed in v6.4, so anything older
> is broken anyways. So effectively we are talking about v6.4 booting
> a v6.5 DT, which is not something we guarantee to be working as far
> as I know.

In general, I do make a point in making things work *in both
directions*. But given that this is an erratum, there isn't much we
can do, and advertising an ITS to a kernel that cannot handle it is
doomed.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2023-07-03 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 16:41 [PATCH v1 1/1] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3588S Sebastian Reichel
2023-07-03 16:41 ` Sebastian Reichel
2023-07-03 16:54 ` Marc Zyngier
2023-07-03 16:54   ` Marc Zyngier
2023-07-03 17:42   ` Sebastian Reichel
2023-07-03 17:42     ` Sebastian Reichel
2023-07-03 18:42     ` Marc Zyngier [this message]
2023-07-03 18:42       ` Marc Zyngier
2023-07-03 19:00 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y1jwx2ek.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=dlan@gentoo.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=sebastian.reichel@collabora.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.