From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: add multi-threaded forcewake support Date: Fri, 18 Nov 2011 14:01:00 -0800 Message-ID: <86y5vdks4j.fsf@sumi.keithp.com> References: <20111118113632.594717c8@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0605976216==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 96E4F9E9DB for ; Fri, 18 Nov 2011 14:01:10 -0800 (PST) In-Reply-To: <20111118113632.594717c8@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0605976216== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 18 Nov 2011 11:36:32 -0800, Jesse Barnes = wrote: > + while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1)) You said this should be << 16 > + I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 1); and this should be << 16 too > + if (I915_READ(ECOBUS) & FORCEWAKE_MT_ENABLE) { ECOBUS (0xa180) is zero on my machine, but I need the new functions. Removing the ECOBUS check and switching the shifts to 16 makes this work on my machine. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUBTsbVnDYtFsjWk68qAQgdrA//StJgRuQbGc1F6vhuZ0EPVc8Ls0CFELB4 k94FGKhnV6k8GHX4ypjj8aKcKg1QmHVczEZWV22boyJZiojEfcaOzCAgDouau8sV 68D6M6w9TztzqhJssi4Srxx8MQEvtYs5xbJdeIAr8TobkNPoHZlGLLSBocsVMToC pDEUvewHgMxt/6SQkYPoZqelMSB/47651zryfz5B9zm91mGpNn4KXDkLite1fgFG hPAI7HZ9IqkJP0uMQBxlXTpPCWHk4IX/uZ2OalvLMytcQ2tuBYixFJf2EOCrycAI LRclMIyD12A3VRb2VMZXADIkdWipxWgfI780cVz8FIv7mHIVw+/crK15LQFUyJ/P Bcr7wNhzMYPkQ3NtAcNStQgu8kQQnNQESefITe+kwfGHmEAw8eM7S7CboDXToMrM aOf293kkdmDsrSJICE7tElXqiSVUKq7b27lkPg4QuumVLasbZkEfKE0eaUhut++Q UbSH/grk/TSNrNxZ+u8p17kxgEmsu/3lAcY+a8CPMYaOZZgAycpLOz00C/exX2ez 9+pqcTxEPWmTkmfNHSR6Sm1uKQI5desxqF2Q9MiH14DD2AbeRmxKjDH88pYK4bzc bVJuGxhJVI+zMH6LZ7686rMD3ShnZ4nmPm6Lhao5CDnTDyoZDVvgpPxrkFbCAbyb dMKL4xhoWJI= =dR9q -----END PGP SIGNATURE----- --=-=-=-- --===============0605976216== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0605976216==--