From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E610352029; Mon, 22 Jun 2026 08:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782117153; cv=none; b=TYkIgkc3Tnjo/OiVlAJfsGvBvyjmSosHq665udyW9ECr/yzVYTOJWN9f6/CfEl1xs8DdnMxPE6KpRTxA795+3HppenxGhKwmLl5fX4IeY69BeghyT35H/rwPFkd/PPgpR2C1lWQ9OyKf/7Z5DLMjzrmmZ+263uqysteAU+qLAYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782117153; c=relaxed/simple; bh=0/UDYSD18AQixTO0MreJwJkIhg5Zq7Efs123Q+njPXM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EmpoefcSmy2hLU6+7FqNVHNKk6foxtZ+Lr8jzGcC4VeTl0oDFctQCqgXtuiS+LX64DIop433fw1OSBenf5+nM0LirsWyBU9NkcOiyk6lSCcU3rzZSMlH69uY0kEHvB7ZnIdbiQhn0rCHou/UuAsY22xm0Ul1V6SwJZ4UUZRiiHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ydm/wFmN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ydm/wFmN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EB5A1F00A3D; Mon, 22 Jun 2026 08:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782117152; bh=tvmBIBVVRuAKAWEBFS4Pm3z5gdPz73I0izorRDkqqWk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Ydm/wFmNFF0Iq5Tm9r+eGjviUImGLb7pUBrLtF3t35nNQjYpBgYfxQfQ6NdsL7qKn c11kMT77DWn0Uz1p+PruEN8d+djWgnR/fyVDg5aoFDpK7fdzfN5zwSMBWvVt6lh9Ty pWxvwu8pGLTISMoMduYleh2zxZyB6H8xC2nY2+Dp22nDhcYd+BobAmTUbhN7GFkOtq Vz+xHmvVxBlnebJB9T1V8Iw33Uu8V8NB1ROc1Gbqu7K/cIu1PAPWb6qo3HJYq3rwJi OeZG6B/B0zumsuSKYicxLrHHXvpSX2kW8lrePdjLT/FjzX8wCjb1i4z3Lc1lBXI/hu E226ukSOX6t6g== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wba50-0000000EqQ0-11iI; Mon, 22 Jun 2026 08:32:30 +0000 Date: Mon, 22 Jun 2026 09:32:29 +0100 Message-ID: <86zf0nq8ki.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon , Bradley Morgan Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: account pKVM reclaim against the VM mm In-Reply-To: <20260621213155.6019-1-include@grrlz.net> References: <20260621213155.6019-1-include@grrlz.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, include@grrlz.net, oupton@kernel.org, tabba@google.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 21 Jun 2026 22:31:55 +0100, Bradley Morgan wrote: > > Protected guest faults charge long term pins to the VM's mm. Teardown > can run later from file release, where current->mm may be unrelated. > > Drop the charge from kvm->mm instead. > > Fixes: 4e6e03f9eadd ("KVM: arm64: Hook up reclaim hypercall to pkvm_pgtable_stage2_destroy()") > Signed-off-by: Bradley Morgan > --- > arch/arm64/kvm/pkvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/pkvm.c b/arch/arm64/kvm/pkvm.c > index 053e4f733e4b..428723b1b0f5 100644 > --- a/arch/arm64/kvm/pkvm.c > +++ b/arch/arm64/kvm/pkvm.c > @@ -352,7 +352,7 @@ static int __pkvm_pgtable_stage2_reclaim(struct kvm_pgtable *pgt, u64 start, u64 > page = pfn_to_page(mapping->pfn); > WARN_ON_ONCE(mapping->nr_pages != 1); > unpin_user_pages_dirty_lock(&page, 1, true); > - account_locked_vm(current->mm, 1, false); > + account_locked_vm(kvm->mm, 1, false); > pkvm_mapping_remove(mapping, &pgt->pkvm_mappings); > kfree(mapping); > } Seems correct to me, as the final mmdrop(kvm->mm) occurs after S2 teardown. Will, what do you think? M. -- Without deviation from the norm, progress is not possible.