From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 851C3227BB9; Mon, 10 Mar 2025 13:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612404; cv=none; b=PpdhNJW4LYMTHsb5sooxElyzBrc2kPDeKJ7Bu1CJr8mtEXP28zyhv6kHE6Ie/AvVVW+/pw52kzgFRyeum0Jr4qhZvRqCPnkH2yvxuv5TLLXmHXCoZ2rlAWaf8ZxOhwZKuZMINyEs5MgOB7MF4U2oczAUk7h3JnpzIpyl/f/faes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612404; c=relaxed/simple; bh=gj+NFBePdsuXWlftWTserZdsRfx1lIS1prLpNJrt8IY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=LyiRge5NgcLUYnExDlmfvJRi/mlur7uF/+U0mFdHy29nBlK2+DO/yekNUbwORRJiJb2Dc3OWxuLsoQ0cqhrcjcbvhGibuXqLALHvDPOevmYSKWEQ21N35WU3tBA6BTmp468Lsjb6AGh1MZZ6Sj87VX7+zCbrlUd3Cyud23v5oAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NyoS4A8R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NyoS4A8R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E86E9C4CEE5; Mon, 10 Mar 2025 13:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741612404; bh=gj+NFBePdsuXWlftWTserZdsRfx1lIS1prLpNJrt8IY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NyoS4A8Rcpq2q6yVbC1dPJiHOuwrTgh4XfLMpr7XuM+J+Nuxjj74AAER0deKQ5R+2 3laMdtWBRoeDU4dT0C6Vxd0JFIUx4p534wxw6LBOaRv7XWesNlyiwuSDV5PlRIL838 HJjUj8G9x0n0fplonOaWRXzR34maagXZIBS98HcHXdOqP2qOQmtSgrvfheQ1RYz5vw Ar6sdxhunSYgv/3Mt6A4zso+Lh4tsbODYaimk5d9nb4rwG1VK9AOI63ciJ/NX9RWl2 sO6QqpP5tirRLYvYLfuBTw5BEm8R0svRdU/x7cT6SPWuzC85Mz1ZHc2Rz4laDNWX/j TlnQWuyTzhDsg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1trcwb-00CBlH-Rv; Mon, 10 Mar 2025 13:13:21 +0000 Date: Mon, 10 Mar 2025 13:13:21 +0000 Message-ID: <86zfhtni4u.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mingwei Zhang , Colton Lewis , Raghavendra Rao Ananta , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Janne Grunau Subject: Re: [PATCH v3 00/14] KVM: arm64: FEAT_PMUv3 on Apple hardware In-Reply-To: <20250305202641.428114-1-oliver.upton@linux.dev> References: <20250305202641.428114-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mizhang@google.com, coltonlewis@google.com, rananta@google.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, j@jannau.net X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 05 Mar 2025 20:26:27 +0000, Oliver Upton wrote: > > Hopefully close to the last spin, this time addressing Marc's comments > on v2. > > Full details found in the v1 cover letter. > > v1: https://lore.kernel.org/kvmarm/20241217212048.3709204-1-oliver.upton@linux.dev/ > v2: https://lore.kernel.org/kvmarm/20250203183111.191519-1-oliver.upton@linux.dev/ > > v2 -> v3: > - Reorder and restructure patches to include map_pmuv3_event() > definition w/ KVM usage. > - Disallow events that lack a valid PMUv3 -> HW mapping > - Various minor fixes/typos > > Oliver Upton (14): > drivers/perf: apple_m1: Refactor event select/filter configuration > drivers/perf: apple_m1: Support host/guest event filtering > KVM: arm64: Compute PMCEID from arm_pmu's event bitmaps > KVM: arm64: Always support SW_INCR PMU event > KVM: arm64: Use a cpucap to determine if system supports FEAT_PMUv3 > KVM: arm64: Drop kvm_arm_pmu_available static key > KVM: arm64: Use guard() to cleanup usage of arm_pmus_lock > KVM: arm64: Move PMUVer filtering into KVM code > KVM: arm64: Compute synthetic sysreg ESR for Apple PMUv3 traps > KVM: arm64: Advertise PMUv3 if IMPDEF traps are present > KVM: arm64: Remap PMUv3 events onto hardware > drivers/perf: apple_m1: Provide helper for mapping PMUv3 events > KVM: arm64: Provide 1 event counter on IMPDEF hardware > arm64: Enable IMP DEF PMUv3 traps on Apple M* > > arch/arm64/include/asm/apple_m1_pmu.h | 1 + > arch/arm64/include/asm/cpucaps.h | 2 + > arch/arm64/include/asm/cpufeature.h | 28 +---- > arch/arm64/kernel/cpu_errata.c | 44 ++++++++ > arch/arm64/kernel/cpufeature.c | 28 +++++ > arch/arm64/kernel/image-vars.h | 5 - > arch/arm64/kvm/arm.c | 4 +- > arch/arm64/kvm/hyp/include/hyp/switch.h | 4 +- > arch/arm64/kvm/hyp/vhe/switch.c | 22 ++++ > arch/arm64/kvm/pmu-emul.c | 138 +++++++++++++++++------- > arch/arm64/kvm/pmu.c | 10 +- > arch/arm64/tools/cpucaps | 2 + > drivers/perf/apple_m1_cpu_pmu.c | 101 +++++++++++++---- > include/kvm/arm_pmu.h | 12 +-- > include/linux/perf/arm_pmu.h | 4 + > 15 files changed, 301 insertions(+), 104 deletions(-) > > > base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319 I'm quite happy with the way this looks now (well, apart from patch #9, but that's not something you can fix...). Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.