From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8551DDC1E; Tue, 17 Dec 2024 10:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734432961; cv=none; b=Duf4YO00/Y75Ld74VhKVI01eJnUoa8I20ZYBPnFWiP1jsECrHpbxhb37aH8YkkcfwTDcPcVjE/NpcjNLcfXmOIDeS9/Hc1QqM11LA7HkTydanFAiXG/mICSwLPMccXvE/RUtM77c8P46Hgcsc72rwHXdKLy1bUIq3g2SZklklXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734432961; c=relaxed/simple; bh=NS1IvYP+0vQDhKLZQWwGEG18/PVpO+pMPWRt8Qw7xiw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=awLMqvCD1YoeoMldR6o58s8FwFws5dpaqi4IJ/l64Ep7/G1AaJ43HOPBXqLXYGfLFMTCJf072OHeCPSrXvBFsKb/XDpZ4inQJdK4WBMXR8bX5zrD3Upodzp9Wku+Vm31v0Hsn3sRJzB2yC6FPzVCSN7cmpee+/i+D8XpFsaeids= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WRTYVhlp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WRTYVhlp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C2B4C4CED3; Tue, 17 Dec 2024 10:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734432960; bh=NS1IvYP+0vQDhKLZQWwGEG18/PVpO+pMPWRt8Qw7xiw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WRTYVhlpsxFgoWDpX90PCgXIn+l8vtZtPdS25P4neZY3A3QAvn7TbdqjhL7yPdUH+ qEdutgCjAH2qWQaSl2x9L3W2HVWMdMTz26X/yX7LIbqCCq2zI8aR/aay+lG6jKKPja ZM2Z+OxqLcQjQza4l9yykfMyR+xyIgWZj+1R9d3GNKUkS0lpRW0idd88Tz0y8HpJr4 jc4bbjGxQIhKwZ0te8QV4HSl9Q4ITa0hjoCR8kmZPq9RiWjgRTGTU7B1xZypR6EvaJ LiwZI/tCO2B1xduU8uPdXAET5lTQrXwc7kRsW9brTgr69ZV9rLLimIx9WIW/x0pIN2 7Djy4CrR4/jlA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tNVF8-004Wc7-M9; Tue, 17 Dec 2024 10:55:58 +0000 Date: Tue, 17 Dec 2024 10:55:58 +0000 Message-ID: <86zfkur329.wl-maz@kernel.org> From: Marc Zyngier To: Quentin Perret Cc: Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Fuad Tabba , Vincent Donnefort , Sebastian Ene , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/18] KVM: arm64: Make hyp_page::order a u8 In-Reply-To: <20241216175803.2716565-4-qperret@google.com> References: <20241216175803.2716565-1-qperret@google.com> <20241216175803.2716565-4-qperret@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qperret@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 16 Dec 2024 17:57:48 +0000, Quentin Perret wrote: > > We don't need 16 bits to store the hyp page order, and we'll need some > bits to store page ownership data soon, so let's reduce the order > member. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/gfp.h | 6 +++--- > arch/arm64/kvm/hyp/include/nvhe/memory.h | 5 +++-- > arch/arm64/kvm/hyp/nvhe/page_alloc.c | 14 +++++++------- > 3 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/gfp.h b/arch/arm64/kvm/hyp/include/nvhe/gfp.h > index 97c527ef53c2..f1725bad6331 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/gfp.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/gfp.h > @@ -7,7 +7,7 @@ > #include > #include > > -#define HYP_NO_ORDER USHRT_MAX > +#define HYP_NO_ORDER 0xff nit: (u8)(~0)? M. -- Without deviation from the norm, progress is not possible.