From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AFB21879 for ; Wed, 31 May 2023 08:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC363C4339B; Wed, 31 May 2023 08:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685522789; bh=JMuzqmUBJoA/r5J0yK+sZwXSCkPl1O+bxFArwcnvsW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fDIwkCIj5dA38T2YdLDzsOvIZHNL6F8EXwkkFaKnevX4oe6gQsFkc+LVPhVu2rpTE ZvHE8ISZCUhzsCQoyWDGDaboDQXQD+zyJIf4vNYmFvR7ra/26EuOo6BCBbZT6r82ob 2FlMJHlnifboxOAQZ+D0EfBUbBU/p1uUdA/Sc1rxjzE7GVyTT7qg8MKDTiQOyPF706 8/nRVcvAVD1hnFNWkjCoTB1WwhCdzLPOKfd7HsDdFCYZddmiFeiNyQBhAfRXx4wSXk ozzW9dKVH0Fc3kewf0I9870I7htmRc+rw8QhnJjI6NqxRXqQl0oKtey9ZRrnwa5wTS 2KId/sKFf7LTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q4HTP-001Z0N-JX; Wed, 31 May 2023 09:46:27 +0100 Date: Wed, 31 May 2023 09:46:27 +0100 Message-ID: <86zg5kc2ho.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , James Morse , Suzuki K Poulose , Ricardo Koller , Paolo Bonzini , Jing Zhang , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 3/6] KVM: arm64: Implement kvm_arch_flush_remote_tlbs_range() In-Reply-To: References: <20230519005231.3027912-1-rananta@google.com> <20230519005231.3027912-4-rananta@google.com> <87v8gbjkzn.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, ricarkol@google.com, pbonzini@redhat.com, jingzhangos@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 30 May 2023 22:22:23 +0100, Raghavendra Rao Ananta wrote: >=20 > On Mon, May 29, 2023 at 7:00=E2=80=AFAM Marc Zyngier wro= te: > > > > On Fri, 19 May 2023 01:52:28 +0100, > > Raghavendra Rao Ananta wrote: > > > > > > Implement kvm_arch_flush_remote_tlbs_range() for arm64 > > > to invalidate the given range in the TLB. > > > > > > Signed-off-by: Raghavendra Rao Ananta > > > --- > > > arch/arm64/include/asm/kvm_host.h | 3 +++ > > > arch/arm64/kvm/hyp/nvhe/tlb.c | 4 +--- > > > arch/arm64/kvm/mmu.c | 11 +++++++++++ > > > 3 files changed, 15 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/a= sm/kvm_host.h > > > index 81ab41b84f436..343fb530eea9c 100644 > > > --- a/arch/arm64/include/asm/kvm_host.h > > > +++ b/arch/arm64/include/asm/kvm_host.h > > > @@ -1081,6 +1081,9 @@ struct kvm *kvm_arch_alloc_vm(void); > > > #define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS > > > int kvm_arch_flush_remote_tlbs(struct kvm *kvm); > > > > > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS_RANGE > > > +int kvm_arch_flush_remote_tlbs_range(struct kvm *kvm, gfn_t start_gf= n, u64 pages); > > > + > > > static inline bool kvm_vm_is_protected(struct kvm *kvm) > > > { > > > return false; > > > diff --git a/arch/arm64/kvm/hyp/nvhe/tlb.c b/arch/arm64/kvm/hyp/nvhe/= tlb.c > > > index d4ea549c4b5c4..d2c7c1bc6d441 100644 > > > --- a/arch/arm64/kvm/hyp/nvhe/tlb.c > > > +++ b/arch/arm64/kvm/hyp/nvhe/tlb.c > > > @@ -150,10 +150,8 @@ void __kvm_tlb_flush_vmid_range(struct kvm_s2_mm= u *mmu, > > > return; > > > } > > > > > > - dsb(ishst); > > > - > > > /* Switch to requested VMID */ > > > - __tlb_switch_to_guest(mmu, &cxt); > > > + __tlb_switch_to_guest(mmu, &cxt, false); > > > > This hunk is in the wrong patch, isn't it? > > > Ah, you are right. It should be part of the previous patch. I think I > introduced it accidentally when I rebased the series. I'll remove it > in the next spin. >=20 >=20 > > > > > > __flush_tlb_range_op(ipas2e1is, start, pages, stride, 0, 0, fal= se); > > > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > > index d0a0d3dca9316..e3673b4c10292 100644 > > > --- a/arch/arm64/kvm/mmu.c > > > +++ b/arch/arm64/kvm/mmu.c > > > @@ -92,6 +92,17 @@ int kvm_arch_flush_remote_tlbs(struct kvm *kvm) > > > return 0; > > > } > > > > > > +int kvm_arch_flush_remote_tlbs_range(struct kvm *kvm, gfn_t start_gf= n, u64 pages) > > > +{ > > > + phys_addr_t start, end; > > > + > > > + start =3D start_gfn << PAGE_SHIFT; > > > + end =3D (start_gfn + pages) << PAGE_SHIFT; > > > + > > > + kvm_call_hyp(__kvm_tlb_flush_vmid_range, &kvm->arch.mmu, start,= end); > > > > So that's the point that I think is not right. It is the MMU code that > > should drive the invalidation method, and not the HYP code. The HYP > > code should be as dumb as possible, and the logic should be kept in > > the MMU code. > > > > So when a range invalidation is forwarded to HYP, it's a *valid* range > > invalidation. not something that can fallback to VMID-wide invalidation. > > > I'm guessing that you are referring to patch-2. Do you recommend > moving the 'pages >=3D MAX_TLBI_RANGE_PAGES' logic here and simply > return an error? How about for the other check: > system_supports_tlb_range()? > The idea was for __kvm_tlb_flush_vmid_range() to also implement a > fallback mechanism in case the system doesn't support the range-based > instructions. But if we end up calling __kvm_tlb_flush_vmid_range() > from multiple cases, we'd end up duplicating the checks. WDYT? My take is that there should be a single helper deciding to issue either a number of range-based TLBIs depending on start/end, or a single VMID-based TLBI. Having multiple calling sites is not a problem, and even if that code gets duplicated, big deal. But a hypercall that falls back to global invalidation based on a range evaluation error (more than MAX_TLBI_RANGE_PAGES) is papering over a latent bug. There should be no logic whatsoever in any of the two tlb.c files. Only a switch to the correct context, and the requested invalidation, which *must* be architecturally correct. Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34959C77B7C for ; Wed, 31 May 2023 08:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1kV1tGEGVVkg5JwT1+Pt9bZ2wfDDfr/H+Zj3L7vlsms=; b=RuNDiSOjbcgJWJ hmFvxH8z02WA9LMD4qJ5beOwKsj/BjVvbHemUGqaXkACWcaJuV8AeaVqZ7AXv+puQGJHIO9GgPOZ2 h/ccS6VOKPMcPOHNWUEHuuYfkZQ1XGITDd2RaiupaN5dfBSkEDHTqihVVE702INN00f2nfZtOTy0U Ds1jSXanJZPnDdz4FQC6oqPe1kXsL8pF35UjiEjLTA1dpbFj6/fpe6GxNa8j1wkCDm89eSPHpbwva SIqCA1yrpPnrrkT49e78skQz4M7ARd9urOKa1jAhiNhjWNY9VK5Cg7qx3Cbdsmi678I0saQNtEMNO Ecx8hos7gL1OnD0Kr9TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4HTY-00GgoY-1a; Wed, 31 May 2023 08:46:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4HTS-00Ggm0-2Z for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 08:46:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5529063854; Wed, 31 May 2023 08:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC363C4339B; Wed, 31 May 2023 08:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685522789; bh=JMuzqmUBJoA/r5J0yK+sZwXSCkPl1O+bxFArwcnvsW0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fDIwkCIj5dA38T2YdLDzsOvIZHNL6F8EXwkkFaKnevX4oe6gQsFkc+LVPhVu2rpTE ZvHE8ISZCUhzsCQoyWDGDaboDQXQD+zyJIf4vNYmFvR7ra/26EuOo6BCBbZT6r82ob 2FlMJHlnifboxOAQZ+D0EfBUbBU/p1uUdA/Sc1rxjzE7GVyTT7qg8MKDTiQOyPF706 8/nRVcvAVD1hnFNWkjCoTB1WwhCdzLPOKfd7HsDdFCYZddmiFeiNyQBhAfRXx4wSXk ozzW9dKVH0Fc3kewf0I9870I7htmRc+rw8QhnJjI6NqxRXqQl0oKtey9ZRrnwa5wTS 2KId/sKFf7LTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q4HTP-001Z0N-JX; Wed, 31 May 2023 09:46:27 +0100 Date: Wed, 31 May 2023 09:46:27 +0100 Message-ID: <86zg5kc2ho.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , James Morse , Suzuki K Poulose , Ricardo Koller , Paolo Bonzini , Jing Zhang , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 3/6] KVM: arm64: Implement kvm_arch_flush_remote_tlbs_range() In-Reply-To: References: <20230519005231.3027912-1-rananta@google.com> <20230519005231.3027912-4-rananta@google.com> <87v8gbjkzn.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, ricarkol@google.com, pbonzini@redhat.com, jingzhangos@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_014630_916606_32AEFADD X-CRM114-Status: GOOD ( 40.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAzMCBNYXkgMjAyMyAyMjoyMjoyMyArMDEwMCwKUmFnaGF2ZW5kcmEgUmFvIEFuYW50 YSA8cmFuYW50YUBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBPbiBNb24sIE1heSAyOSwgMjAyMyBh dCA3OjAw4oCvQU0gTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4g T24gRnJpLCAxOSBNYXkgMjAyMyAwMTo1MjoyOCArMDEwMCwKPiA+IFJhZ2hhdmVuZHJhIFJhbyBB bmFudGEgPHJhbmFudGFAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEltcGxlbWVudCBr dm1fYXJjaF9mbHVzaF9yZW1vdGVfdGxic19yYW5nZSgpIGZvciBhcm02NAo+ID4gPiB0byBpbnZh bGlkYXRlIHRoZSBnaXZlbiByYW5nZSBpbiB0aGUgVExCLgo+ID4gPgo+ID4gPiBTaWduZWQtb2Zm LWJ5OiBSYWdoYXZlbmRyYSBSYW8gQW5hbnRhIDxyYW5hbnRhQGdvb2dsZS5jb20+Cj4gPiA+IC0t LQo+ID4gPiAgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIHwgIDMgKysrCj4gPiA+ ICBhcmNoL2FybTY0L2t2bS9oeXAvbnZoZS90bGIuYyAgICAgfCAgNCArLS0tCj4gPiA+ICBhcmNo L2FybTY0L2t2bS9tbXUuYyAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrKwo+ID4gPiAgMyBm aWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4g PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIGIvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oCj4gPiA+IGluZGV4IDgxYWI0MWI4NGY0MzYuLjM0 M2ZiNTMwZWVhOWMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20va3Zt X2hvc3QuaAo+ID4gPiArKysgYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmgKPiA+ ID4gQEAgLTEwODEsNiArMTA4MSw5IEBAIHN0cnVjdCBrdm0gKmt2bV9hcmNoX2FsbG9jX3ZtKHZv aWQpOwo+ID4gPiAgI2RlZmluZSBfX0tWTV9IQVZFX0FSQ0hfRkxVU0hfUkVNT1RFX1RMQlMKPiA+ ID4gIGludCBrdm1fYXJjaF9mbHVzaF9yZW1vdGVfdGxicyhzdHJ1Y3Qga3ZtICprdm0pOwo+ID4g Pgo+ID4gPiArI2RlZmluZSBfX0tWTV9IQVZFX0FSQ0hfRkxVU0hfUkVNT1RFX1RMQlNfUkFOR0UK PiA+ID4gK2ludCBrdm1fYXJjaF9mbHVzaF9yZW1vdGVfdGxic19yYW5nZShzdHJ1Y3Qga3ZtICpr dm0sIGdmbl90IHN0YXJ0X2dmbiwgdTY0IHBhZ2VzKTsKPiA+ID4gKwo+ID4gPiAgc3RhdGljIGlu bGluZSBib29sIGt2bV92bV9pc19wcm90ZWN0ZWQoc3RydWN0IGt2bSAqa3ZtKQo+ID4gPiAgewo+ ID4gPiAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2 bS9oeXAvbnZoZS90bGIuYyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL3RsYi5jCj4gPiA+IGlu ZGV4IGQ0ZWE1NDljNGI1YzQuLmQyYzdjMWJjNmQ0NDEgMTAwNjQ0Cj4gPiA+IC0tLSBhL2FyY2gv YXJtNjQva3ZtL2h5cC9udmhlL3RsYi5jCj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9u dmhlL3RsYi5jCj4gPiA+IEBAIC0xNTAsMTAgKzE1MCw4IEBAIHZvaWQgX19rdm1fdGxiX2ZsdXNo X3ZtaWRfcmFuZ2Uoc3RydWN0IGt2bV9zMl9tbXUgKm1tdSwKPiA+ID4gICAgICAgICAgICAgICBy ZXR1cm47Cj4gPiA+ICAgICAgIH0KPiA+ID4KPiA+ID4gLSAgICAgZHNiKGlzaHN0KTsKPiA+ID4g LQo+ID4gPiAgICAgICAvKiBTd2l0Y2ggdG8gcmVxdWVzdGVkIFZNSUQgKi8KPiA+ID4gLSAgICAg X190bGJfc3dpdGNoX3RvX2d1ZXN0KG1tdSwgJmN4dCk7Cj4gPiA+ICsgICAgIF9fdGxiX3N3aXRj aF90b19ndWVzdChtbXUsICZjeHQsIGZhbHNlKTsKPiA+Cj4gPiBUaGlzIGh1bmsgaXMgaW4gdGhl IHdyb25nIHBhdGNoLCBpc24ndCBpdD8KPiA+Cj4gQWgsIHlvdSBhcmUgcmlnaHQuIEl0IHNob3Vs ZCBiZSBwYXJ0IG9mIHRoZSBwcmV2aW91cyBwYXRjaC4gSSB0aGluayBJCj4gaW50cm9kdWNlZCBp dCBhY2NpZGVudGFsbHkgd2hlbiBJIHJlYmFzZWQgdGhlIHNlcmllcy4gSSdsbCByZW1vdmUgaXQK PiBpbiB0aGUgbmV4dCBzcGluLgo+IAo+IAo+ID4gPgo+ID4gPiAgICAgICBfX2ZsdXNoX3RsYl9y YW5nZV9vcChpcGFzMmUxaXMsIHN0YXJ0LCBwYWdlcywgc3RyaWRlLCAwLCAwLCBmYWxzZSk7Cj4g PiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9tbXUuYyBiL2FyY2gvYXJtNjQv a3ZtL21tdS5jCj4gPiA+IGluZGV4IGQwYTBkM2RjYTkzMTYuLmUzNjczYjRjMTAyOTIgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2FyY2gvYXJtNjQva3ZtL21tdS5jCj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQv a3ZtL21tdS5jCj4gPiA+IEBAIC05Miw2ICs5MiwxNyBAQCBpbnQga3ZtX2FyY2hfZmx1c2hfcmVt b3RlX3RsYnMoc3RydWN0IGt2bSAqa3ZtKQo+ID4gPiAgICAgICByZXR1cm4gMDsKPiA+ID4gIH0K PiA+ID4KPiA+ID4gK2ludCBrdm1fYXJjaF9mbHVzaF9yZW1vdGVfdGxic19yYW5nZShzdHJ1Y3Qg a3ZtICprdm0sIGdmbl90IHN0YXJ0X2dmbiwgdTY0IHBhZ2VzKQo+ID4gPiArewo+ID4gPiArICAg ICBwaHlzX2FkZHJfdCBzdGFydCwgZW5kOwo+ID4gPiArCj4gPiA+ICsgICAgIHN0YXJ0ID0gc3Rh cnRfZ2ZuIDw8IFBBR0VfU0hJRlQ7Cj4gPiA+ICsgICAgIGVuZCA9IChzdGFydF9nZm4gKyBwYWdl cykgPDwgUEFHRV9TSElGVDsKPiA+ID4gKwo+ID4gPiArICAgICBrdm1fY2FsbF9oeXAoX19rdm1f dGxiX2ZsdXNoX3ZtaWRfcmFuZ2UsICZrdm0tPmFyY2gubW11LCBzdGFydCwgZW5kKTsKPiA+Cj4g PiBTbyB0aGF0J3MgdGhlIHBvaW50IHRoYXQgSSB0aGluayBpcyBub3QgcmlnaHQuIEl0IGlzIHRo ZSBNTVUgY29kZSB0aGF0Cj4gPiBzaG91bGQgZHJpdmUgdGhlIGludmFsaWRhdGlvbiBtZXRob2Qs IGFuZCBub3QgdGhlIEhZUCBjb2RlLiBUaGUgSFlQCj4gPiBjb2RlIHNob3VsZCBiZSBhcyBkdW1i IGFzIHBvc3NpYmxlLCBhbmQgdGhlIGxvZ2ljIHNob3VsZCBiZSBrZXB0IGluCj4gPiB0aGUgTU1V IGNvZGUuCj4gPgo+ID4gU28gd2hlbiBhIHJhbmdlIGludmFsaWRhdGlvbiBpcyBmb3J3YXJkZWQg dG8gSFlQLCBpdCdzIGEgKnZhbGlkKiByYW5nZQo+ID4gaW52YWxpZGF0aW9uLiBub3Qgc29tZXRo aW5nIHRoYXQgY2FuIGZhbGxiYWNrIHRvIFZNSUQtd2lkZSBpbnZhbGlkYXRpb24uCj4gPgo+IEkn bSBndWVzc2luZyB0aGF0IHlvdSBhcmUgcmVmZXJyaW5nIHRvIHBhdGNoLTIuIERvIHlvdSByZWNv bW1lbmQKPiBtb3ZpbmcgdGhlICdwYWdlcyA+PSBNQVhfVExCSV9SQU5HRV9QQUdFUycgbG9naWMg aGVyZSBhbmQgc2ltcGx5Cj4gcmV0dXJuIGFuIGVycm9yPyBIb3cgYWJvdXQgZm9yIHRoZSBvdGhl ciBjaGVjazoKPiBzeXN0ZW1fc3VwcG9ydHNfdGxiX3JhbmdlKCk/Cj4gVGhlIGlkZWEgd2FzIGZv ciBfX2t2bV90bGJfZmx1c2hfdm1pZF9yYW5nZSgpIHRvIGFsc28gaW1wbGVtZW50IGEKPiBmYWxs YmFjayBtZWNoYW5pc20gaW4gY2FzZSB0aGUgc3lzdGVtIGRvZXNuJ3Qgc3VwcG9ydCB0aGUgcmFu Z2UtYmFzZWQKPiBpbnN0cnVjdGlvbnMuIEJ1dCBpZiB3ZSBlbmQgdXAgY2FsbGluZyBfX2t2bV90 bGJfZmx1c2hfdm1pZF9yYW5nZSgpCj4gZnJvbSBtdWx0aXBsZSBjYXNlcywgd2UnZCBlbmQgdXAg ZHVwbGljYXRpbmcgdGhlIGNoZWNrcy4gV0RZVD8KCk15IHRha2UgaXMgdGhhdCB0aGVyZSBzaG91 bGQgYmUgYSBzaW5nbGUgaGVscGVyIGRlY2lkaW5nIHRvIGlzc3VlCmVpdGhlciBhIG51bWJlciBv ZiByYW5nZS1iYXNlZCBUTEJJcyBkZXBlbmRpbmcgb24gc3RhcnQvZW5kLCBvciBhCnNpbmdsZSBW TUlELWJhc2VkIFRMQkkuIEhhdmluZyBtdWx0aXBsZSBjYWxsaW5nIHNpdGVzIGlzIG5vdCBhCnBy b2JsZW0sIGFuZCBldmVuIGlmIHRoYXQgY29kZSBnZXRzIGR1cGxpY2F0ZWQsIGJpZyBkZWFsLgoK QnV0IGEgaHlwZXJjYWxsIHRoYXQgZmFsbHMgYmFjayB0byBnbG9iYWwgaW52YWxpZGF0aW9uIGJh c2VkIG9uIGEKcmFuZ2UgZXZhbHVhdGlvbiBlcnJvciAobW9yZSB0aGFuIE1BWF9UTEJJX1JBTkdF X1BBR0VTKSBpcyBwYXBlcmluZwpvdmVyIGEgbGF0ZW50IGJ1Zy4KClRoZXJlIHNob3VsZCBiZSBu byBsb2dpYyB3aGF0c29ldmVyIGluIGFueSBvZiB0aGUgdHdvIHRsYi5jIGZpbGVzLgpPbmx5IGEg c3dpdGNoIHRvIHRoZSBjb3JyZWN0IGNvbnRleHQsIGFuZCB0aGUgcmVxdWVzdGVkIGludmFsaWRh dGlvbiwKd2hpY2ggKm11c3QqIGJlIGFyY2hpdGVjdHVyYWxseSBjb3JyZWN0LgoKVGhhbmtzLAoK CU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90 IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=