All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Usama Arif <usama.arif@bytedance.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-doc@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux@armlinux.org.uk,
	yezengruan@huawei.com, catalin.marinas@arm.com, will@kernel.org,
	steven.price@arm.com, mark.rutland@arm.com, bagasdotme@gmail.com,
	pbonzini@redhat.com, fam.zheng@bytedance.com,
	liangma@liangbit.com, punit.agrawal@bytedance.com
Subject: Re: [v3 0/6] KVM: arm64: implement vcpu_is_preempted check
Date: Tue, 14 Feb 2023 16:49:51 +0000	[thread overview]
Message-ID: <86zg9gxkcw.wl-maz@kernel.org> (raw)
In-Reply-To: <5976b0c9-d4e7-7561-6ce0-790e2460d1ef@bytedance.com>

On Tue, 14 Feb 2023 16:06:26 +0000,
Usama Arif <usama.arif@bytedance.com> wrote:
> 
> 
> 
> On 17/01/2023 10:29, Usama Arif wrote:
> > This patchset adds support for vcpu_is_preempted in arm64, which allows the guest
> > to check if a vcpu was scheduled out, which is useful to know incase it was
> > holding a lock. vcpu_is_preempted is well integrated in core kernel code and can
> > be used to improve performance in locking (owner_on_cpu usage in mutex_spin_on_owner,
> > mutex_can_spin_on_owner, rtmutex_spin_on_owner and osq_lock) and scheduling
> > (available_idle_cpu which is used in several places in kernel/sched/fair.c
> > for e.g. in wake_affine to determine which CPU can run soonest).
> > 
> > This patchset shows significant improvement on overcommitted hosts (vCPUs > pCPUS),
> > as waiting for preempted vCPUs reduces performance.
> > 
> 
> Hi,
> 
> Just wanted to check if there are any comments for this?

Not a lot, I'm afraid. My concerns with this thing are still the same:

- it is KVM-specific
- it doesn't work with nested virtualisation
- its correctness is unproven on arm64

I'm also not going to entertain any of this without the core arm64
maintainers saying that they will enable this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Usama Arif <usama.arif@bytedance.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-doc@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux@armlinux.org.uk,
	yezengruan@huawei.com, catalin.marinas@arm.com, will@kernel.org,
	steven.price@arm.com, mark.rutland@arm.com, bagasdotme@gmail.com,
	pbonzini@redhat.com, fam.zheng@bytedance.com,
	liangma@liangbit.com, punit.agrawal@bytedance.com
Subject: Re: [v3 0/6] KVM: arm64: implement vcpu_is_preempted check
Date: Tue, 14 Feb 2023 16:49:51 +0000	[thread overview]
Message-ID: <86zg9gxkcw.wl-maz@kernel.org> (raw)
In-Reply-To: <5976b0c9-d4e7-7561-6ce0-790e2460d1ef@bytedance.com>

On Tue, 14 Feb 2023 16:06:26 +0000,
Usama Arif <usama.arif@bytedance.com> wrote:
> 
> 
> 
> On 17/01/2023 10:29, Usama Arif wrote:
> > This patchset adds support for vcpu_is_preempted in arm64, which allows the guest
> > to check if a vcpu was scheduled out, which is useful to know incase it was
> > holding a lock. vcpu_is_preempted is well integrated in core kernel code and can
> > be used to improve performance in locking (owner_on_cpu usage in mutex_spin_on_owner,
> > mutex_can_spin_on_owner, rtmutex_spin_on_owner and osq_lock) and scheduling
> > (available_idle_cpu which is used in several places in kernel/sched/fair.c
> > for e.g. in wake_affine to determine which CPU can run soonest).
> > 
> > This patchset shows significant improvement on overcommitted hosts (vCPUs > pCPUS),
> > as waiting for preempted vCPUs reduces performance.
> > 
> 
> Hi,
> 
> Just wanted to check if there are any comments for this?

Not a lot, I'm afraid. My concerns with this thing are still the same:

- it is KVM-specific
- it doesn't work with nested virtualisation
- its correctness is unproven on arm64

I'm also not going to entertain any of this without the core arm64
maintainers saying that they will enable this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-14 16:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 10:29 [v3 0/6] KVM: arm64: implement vcpu_is_preempted check Usama Arif
2023-01-17 10:29 ` Usama Arif
2023-01-17 10:29 ` [v3 1/6] KVM: arm64: Document PV-lock interface Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-01-18 13:29   ` Bagas Sanjaya
2023-01-18 13:29     ` Bagas Sanjaya
2023-01-17 10:29 ` [v3 2/6] KVM: arm64: Add SMCCC paravirtualised lock calls Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-01-17 10:29 ` [v3 3/6] KVM: arm64: Support pvlock preempted via shared structure Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-01-17 10:29 ` [v3 4/6] KVM: arm64: Provide VCPU attributes for PV lock Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-01-17 10:29 ` [v3 5/6] KVM: arm64: Support the VCPU preemption check Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-01-17 10:29 ` [v3 6/6] KVM: selftests: add tests for PV time specific hypercall Usama Arif
2023-01-17 10:29   ` Usama Arif
2023-02-14 16:06 ` [v3 0/6] KVM: arm64: implement vcpu_is_preempted check Usama Arif
2023-02-14 16:06   ` Usama Arif
2023-02-14 16:49   ` Marc Zyngier [this message]
2023-02-14 16:49     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zg9gxkcw.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=bagasdotme@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=fam.zheng@bytedance.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=liangma@liangbit.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=punit.agrawal@bytedance.com \
    --cc=steven.price@arm.com \
    --cc=usama.arif@bytedance.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will@kernel.org \
    --cc=yezengruan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.