From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 1/1 v2] mmc_utils: add ffu support Date: Fri, 26 Feb 2016 14:45:05 +0000 Message-ID: <86ziuncyz2.fsf@void.printf.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from void.printf.net ([192.34.86.38]:56915 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932066AbcBZOw3 convert rfc822-to-8bit (ORCPT ); Fri, 26 Feb 2016 09:52:29 -0500 In-Reply-To: (Avi Shchislowski's message of "Tue, 23 Feb 2016 11:27:44 +0000") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Avi Shchislowski Cc: Ulf Hansson , "linux-mmc@vger.kernel.org" , Alex Lemberg , Yaniv Agman Hi Avi, On Tue, Feb 23 2016, Avi Shchislowski wrote: > Adding support for field firmware update over multiple command ioctl. > As multiple command ioctl is supported only from kernel 4.4, this pat= ch should be used against kernel 4.4 and above. > > Known issues: > - There is no support for Multiple Block write commands (CMD25) in ex= isting=20 > IOCTL implementation > - In case MODE_OPERATION_CODES field is not supported by the device > manual reset of the device/platform is required. > The reset issue discussed in another email thread - " [RFC 0/6] mm= c: Field Firmware Update" > > Change since v1: > - modified copyright header > > Signed-off-by: Yaniv Agman > Signed-off-by: Avi Shchislowski Thanks for resending. I'm getting some compile errors, any ideas? mmc_cmds.c: In function =E2=80=98do_ffu=E2=80=99: mmc_cmds.c:2076:31: error: invalid application of =E2=80=98sizeof=E2=80= =99 to incomplete type =E2=80=98struct mmc_ioc_multi_cmd=E2=80=99 multi_cmd =3D calloc(1, sizeof(struct mmc_ioc_multi_cmd) + ^ mmc_cmds.c:2126:11: error: dereferencing pointer to incomplete type =E2= =80=98struct mmc_ioc_multi_cmd=E2=80=99 multi_cmd->num_of_cmds =3D 3; ^ mmc_cmds.c:2162:23: error: =E2=80=98MMC_IOC_MULTI_CMD=E2=80=99 undeclar= ed (first use in this function) ret =3D ioctl(dev_fd, MMC_IOC_MULTI_CMD, multi_cmd); ^ - Chris. --=20 Chris Ball