All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: yocto-patches@lists.yoctoproject.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Yoann Congal <yoann.congal@smile.fr>
Subject: Re: [yocto-patches] [yocto-autobuilder-helper][PATCH] scripts/yocto-supported-distros: fix an incorrect regular expression for stream
Date: Wed, 08 Apr 2026 11:14:17 +0100	[thread overview]
Message-ID: <8701b1c37a2d192c4d8698eee648025ea632060c.camel@linuxfoundation.org> (raw)
In-Reply-To: <DHNLEVZSJENP.8TRZXPDC4RO3@bootlin.com>

On Wed, 2026-04-08 at 09:25 +0200, Antonin Godard via
lists.yoctoproject.org wrote:
> Hi,
> 
> On Mon Apr 6, 2026 at 10:49 AM CEST, Paul Barker wrote:
> > On Thu, 2026-03-26 at 17:22 +0100, Antonin Godard via
> > lists.yoctoproject.org wrote:
> > > The lsb string for CentOS Stream is actually centosstream-*, not
> > > centos-*. It was thus not detecting centosstream entries in
> > > SANITY_TESTED_DISTROS.
> > > 
> > > This was preventing the script from outputting the docs-formatted
> > > CentOS
> > > strings.
> > > 
> > > Reported-by: Yoann Congal <yoann.congal@smile.fr>
> > > Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
> > > ---
> > >  scripts/yocto-supported-distros | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/scripts/yocto-supported-distros b/scripts/yocto-
> > > supported-distros
> > > index 11b05b7..f1dac04 100755
> > > --- a/scripts/yocto-supported-distros
> > > +++ b/scripts/yocto-supported-distros
> > > @@ -83,7 +83,7 @@ INPUT_REGEXES = {
> > >      },
> > >      "centosstream": {
> > >          "ab": re.compile(r"^stream(\d+)"),
> > > -        "lsb": re.compile(r"^stream-(\d+)"),
> > > +        "lsb": re.compile(r"^centosstream-(\d+)"),
> > 
> > Hi Antonin,
> > 
> > Where do you see centosstream-* reported?
> > 
> > On the stream9-vk-1 autobuilder worker and on a local centos stream
> > 9
> > instance I see "centos-9":
> > 
> >     $ ( source /etc/os-release && echo $ID-$VERSION_ID )
> >     centos-9
> > 
> > We currently have "centosstream-9" listed as a supported distro,
> > but if
> > I build on stream9-vk-1 I see:
> > 
> >     WARNING: Host distribution "centos-9" has not been validated
> > with
> >     this version of the build system; you may possibly experience
> >     unexpected failures. It is recommended that you use a tested
> >     distribution.
> > 
> > So, I sent a patch for meta-yocto [1]. We should try to resolve
> > which
> > one is correct.
> > 
> > [1]:
> > https://lore.kernel.org/poky/20260403-centos-9-v1-1-e5324bd74ea3@pbarker.dev/T/
> 
> I'm a bit confused, why was this not a problem on whinlatter and
> scarthgap then?
> Both of them have either centosstream-8 or centosstream-9 as their
> lsb string in
> poky.conf.
> 
> https://git.yoctoproject.org/meta-yocto/tree/meta-poky/conf/distro/poky.conf?h=whinlatter
> https://git.yoctoproject.org/meta-yocto/tree/meta-poky/conf/distro/poky.conf?h=scarthgap
> 
> Even CentOS Stream 8 images report centos-8 (with a local docker
> image):
> 
> $ docker run --rm -it quay.io/centos/centos:stream8 bash
> [root@c33732bb804a /]# cat /etc/os-release
> NAME="CentOS Stream"
> VERSION="8"
> ID="centos"
> ID_LIKE="rhel fedora"
> VERSION_ID="8"
> 
> Should we backport your change to both of these branches?

It does sound like we got that wrong so yes, we should probably fix it.

Cheers,

Richard


      reply	other threads:[~2026-04-08 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 16:22 [yocto-autobuilder-helper][PATCH] scripts/yocto-supported-distros: fix an incorrect regular expression for stream Antonin Godard
2026-04-06  8:49 ` [yocto-patches] " Paul Barker
2026-04-07 10:58   ` Antonin Godard
2026-04-07 11:14     ` Richard Purdie
2026-04-08  7:25   ` Antonin Godard
2026-04-08 10:14     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8701b1c37a2d192c4d8698eee648025ea632060c.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yoann.congal@smile.fr \
    --cc=yocto-patches@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.