From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B0A4C46CA2 for ; Tue, 19 Dec 2023 08:00:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.656572.1024868 (Exim 4.92) (envelope-from ) id 1rFV1h-0000R1-Vu; Tue, 19 Dec 2023 08:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 656572.1024868; Tue, 19 Dec 2023 08:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFV1h-0000Qu-T4; Tue, 19 Dec 2023 08:00:29 +0000 Received: by outflank-mailman (input) for mailman id 656572; Tue, 19 Dec 2023 08:00:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFV1g-0006W2-Aj for xen-devel@lists.xenproject.org; Tue, 19 Dec 2023 08:00:28 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id abdca79b-9e44-11ee-98eb-6d05b1d4d9a1; Tue, 19 Dec 2023 09:00:27 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 065DE4EE0738; Tue, 19 Dec 2023 09:00:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abdca79b-9e44-11ee-98eb-6d05b1d4d9a1 MIME-Version: 1.0 Date: Tue, 19 Dec 2023 09:00:27 +0100 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Simone Ballarin , Doug Goldstein Subject: Re: [XEN PATCH v2 7/7] automation/eclair_analysis: avoid violation of MISRA Rule 2.1 In-Reply-To: References: <6bf425b3d01dc16297ef45e58c03b3ffd803b9e0.1702891792.git.nicola.vetrini@bugseng.com> Message-ID: <8707dd8023b0e05efaf46e7afb3b85cb@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2023-12-19 02:43, Stefano Stabellini wrote: > On Mon, 18 Dec 2023, Stefano Stabellini wrote: >> On Mon, 18 Dec 2023, Nicola Vetrini wrote: >> > The presence of an unlinked object file triggers a violation >> > of MISRA C Rule 2.1, which is deviated, as it's not part of >> > the final Xen binary. >> > >> > No functional change. >> > >> > Signed-off-by: Nicola Vetrini >> >> Acked-by: Stefano Stabellini >> >> >> > --- >> > automation/eclair_analysis/ECLAIR/deviations.ecl | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl >> > index 85741a2c01a9..e3de0fb2adf8 100644 >> > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >> > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >> > @@ -28,6 +28,11 @@ not executable, and therefore it is safe for them to be unreachable." >> > -config=MC3R1.R2.1,ignored_stmts+={"any()", "pure_decl()"} >> > -doc_end >> > >> > ++-doc_begin="The following autogenerated file is not linked deliberately." >> > ++-file_tag+={C_runtime_failures,"^automation/eclair_analysis/C-runtime-failures\\.rst\\.c$"} >> > ++-config=MC3R1.R2.1,reports+={deliberate, "any_area(any_loc(file(C_runtime_failures)))"} >> > ++-doc_end > > Would it make sense to add it to exclude-list instead? I don't think so, because if some documentation about runtime error that is supposed to be here is missing it won't be obvious that the file that needs to be fixed is this. Moreover, you'd need to put the path of the generated .c file there, which I'm not sure how well it would behave w.r.t. other tooling. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)