From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB209258EE9; Thu, 20 Aug 2026 14:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787235393; cv=none; b=FsFYPEQeLUh+OJ/vtSYPkzfbENU62GHBj8o37rVr9HnUimZ6cQUGeFDedkyx/BOHi+291lGqsawNfoqsbSvcpKpeBI2kxsQvnm4KLICkCiLaFwvUvhz207HVQR/FQ285hr4I768RePkC5Zlj9Yud7yVYeXXTpII9pKJ8nfnOgjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787235393; c=relaxed/simple; bh=ne8UKQqykdUM1FqeQsf/i5+3ZCLGHZmKICQgnDK8mmA=; h=Message-ID:Date:MIME-Version:Subject:Cc:References:From:To: In-Reply-To:Content-Type; b=ZcuVyIA8vbWxNS2q3swomYnTd59P7XzetHRnmKxpzXqZS0wtl464OyA2cx3SQz+igjtyKjiFSNScaIw52gLBp6wk5AxcE0eoMuTZFk4X3DLxwTh034CeWTikV1/m2Fb8oPe21p+r/caHJKLkKAReGxsDYfXnBg7+KHKo+TEUbPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=H4j/HHoQ; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="H4j/HHoQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1787235369; x=1787840169; i=markus.elfring@web.de; bh=ne8UKQqykdUM1FqeQsf/i5+3ZCLGHZmKICQgnDK8mmA=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:Cc: References:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=H4j/HHoQTnV4o7M12B6f9evilkEa5ycGShW7iQyaFTpG86HJ47VETRSCG7hiVcWB 8ilN91sDGQZ/4pKznnVgYq7nr1Djc5bblhFCUgJTKmnb6Si0nIs7Y+9X0pDvJWZtC webGTV29tZMyMoebhVsdjiCZISUOKOEoJRt9xwslHi1yZHl/j3phGWZAJKJdKWEx+ vi61AdEM3UczWD1An3DFtiTUUAL1DrbtayZ+EnQc9655AyWo24fW8SK7r4lJvWCti dJz8RlFaibX4wWpiGVYgVe/agMSwXvtp+CzqekDd9/C5AWi29GyIiQAWnf9n5CZDl iHORUh2dr2OCY5v2cA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N6bD0-1wtSEx11na-00xGRV; Thu, 20 Aug 2026 16:16:09 +0200 Message-ID: <87126df0-d332-48e7-b128-a96d6a8330d8@web.de> Date: Thu, 20 Aug 2026 16:16:07 +0200 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] perf/dwc_pcie: Fix PCI device reference leak in probe Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20260820135611.3901886-1-ruoyuw560@gmail.com> Content-Language: en-GB, de-DE From: Markus Elfring To: Ruoyu Wang , linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jing Zhang , Mark Rutland , Shuai Xue , Will Deacon , Yunhui Cui In-Reply-To: <20260820135611.3901886-1-ruoyuw560@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:WqrjtmnDMXHmqRVTnqnOARnLZSrj9moSoeImG4ffQI+orAo0ZXa WGFFO30WLe6pZGiD/2A+pz9cXnuG/pilogiqGA8GQhq0duAktC0nR2Wb5nDScd+XGVB4a8u +xfJUhj0MBAmT9eq454QszTpuNtN9DyL76l1WqxiDvP7YW9rv/U+NiO5jEU5Lsu0LkJ0e41 vN7VXgv6eH1s6TX6bel4w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XMke1zJ7Y2I=;x2UZ2ahTexPe+Tt1yOB35Y4Xkmi C5Q5CE2ZMBFm5FowqAW/Hb0rurbPWcU0r2VJDy7gvjDITXIPuOt6Twpqv3mri3ujb3MX++3c+ IedG+ssI0OSt9F25Yo3b3rcHXYY2wh9boATSper6gPfkc6uIDJz3Li3yhtHIjmmTIsoXcB05I OrUO/VlXWq/LJF9ivjA0RE0+ER4R/iV/2MXzd6YJyE13x/ZPemW+kCBjsagGz7fgWVnMRIl2w 9via4LPYBX7ajaupor2FKMLMTLTS+sGWxyjBlsN1PaXBT01i5E6mDHvVoZUb3ah4V8i9yxNAA 4BnkcWSfF6ENf+FL9QoBIKfmn1VdRWMkQXBlAB4D2nLAsjLl2k15/ewADst11nx4J4xdbwMUZ I8S6dOEWD5nvau3Z0hwYYqpdCj6IXoqukxyN8KMKxQrZtdpH/C0NCiUuny0k6XyClHP5BxRHV tqs1D4GSrf4SGgXrGH14+Euo9IcgZgGXrWa5CRj/1MHD2ctJOko6UjsMVPXUXGhjHwWkAWZCL cdG2SV/kbD9YXKL3dc8XBQbo+o0oIL2tYxSieMgDgQpTDOHkxA+TVRsJUG6YqqR5ZEHFO8yRo djCToXgMU7hrNMlUL+z6sC5i8PwBYEU77wqrc3mfyND6Y0xsLxI0AjSt9uwzuUb/b5BwDPwQR rJkxZ2JJz31eCNkuQrZdKC5B80JBvUlXKQ/vYkAsTbrGnBD4Iu35cn6dRkMRP1d4+rElsJK0N REYEciMDZNND6LiakDAGjRMYeRZdEDHSL0s3jrs7CZGDNlB5Ch5qTXuTIYWvBQiWPaLibvV0B CtSivQaQqQIdvIa3Z+YP99C5QrSmYmHQgoxTMXjc+o/AWe4xa0BtQEExeTPx5dMjpZaIhDV7z utVK2g0iBzPorAApTqv9AAtWnaa8P81yDru0zt35NMthJblzoojv97uTYAnMosPO1+mlqWq1a lqJgA7nQHdKz8C70rd2ev3gH3Tnv7GOv444sH+n464BkbUbJ8MZmDSUuP2D08dcEmojo96rOf GPWqV51lVea9KgAB1IEKrVKHE4sfIntbUfpvZSN3s7shE1tWt3j3PWvA8iB4IHvNYmR1mBS2C DJbTMtnzam8x68/KBpx7wzgKhvg6lb8DXFvTzhyf1wq+oHB7JpSW0Ao81TQPIAkq1F0qYbyH1 jOWcUgzRSk2ItVcUywZ3xIEUAJK/oSV7bjDbA351nNl1QbJuKh000ENK1A3gUm2VCioz2k9x0 2gh6cFxE4CeVqfs/2pGECv+mxWS9fFOY9TZqVQ1n6RiifHHWLyGnL+6nxjZoh5jcKakHe/FsA 9WSWGuhZTBLj/ndAHbVq7pCVZ0Ex3Y5XiM5EgblxEALlKsctddlRt4NdQ9WzCgGy3n1i2GWdU HPBj/eJdgTSkqHdtcKc/uWULIkjBWJQi0f5kWnrsKm9KRpmVwyMGgSdkhFX6qOAxbCUeuQjsU SNTUldt449uUxdytZ0fASO8tCcJymjUGkVP6d54V8OO6Fd66oU2+xRoPJ4rDFDgRFEQ3Eg46N +O9EHMqh14A+VJfcqC4DzTagV6epyCcVTE9FuHcFo5TfuMjUsl8VAhZUsDWzcuk19rb59k3Ei mbBosvXwjniUfflhD5BF05y49BoNSvOfheFXTQuogEXMY1O46hZ785dEHdUDjJEEq2sLjrYQd nRRrYFPdjKmtqRjlgMYNv6UVFehaNpXZvxDFhXzoqzXuzQhhIYFyKoDCAra4RbdVgwsBnxpde 14QAuIBeoUzTCA0sY0kWpvYwzex9OmrLmFka34Ivi9ijvsT0EayKdjfv/1bNvXlOd1Oo93cQ6 S3nrcl/JEZhffzcy0ly6o1yVMbfjlc4tOCq3yA1uwddbcqXKDKBnMEabKe+hr4Ie0Glm+ye86 dYBHfyuWWQZHFY0nCtdzs59EVzzJOrO3LemlSVHbNBaDJFLvY1dDBh+KcAQ0Y7r0WvvBI+fkm DeF8aXrSa7DQi6jGuQXDSk4VtWFN+szfeIytHoDVuLBmfRt0aude8BEt2d/aB/T2Yz77XDq+p 9fHWUCEn9Catek/sbFwqhX8yJwbs+YeV7yGT9KSwmkPi0ZzWGtsXfqujKFC8+6ID8EY713Tgb oFnAYk3lvYKZGtkuwHXdha1dbzmq789pDVG4YcmWa8GNYsVrMhz064xS0yasVcQn/BxKgq2sw eSQHVG+Gr5/YcplG7KXpR+xXCLWAyqRG+74bCSe870ZFkZ6IxumLVlwyRhdHZOqYbGIUTYnhh eXKDIdqIchDuxjAbs8/S8lGKIgA1Thzjcii52iyPHHA+DXqgvfHTAghWxz/gVpVBOVe5aSK4A RjVa5tmgRwJXryPqsIpd592WqAh81S4ZutFSxSi62waozaq6IMPgGAtwZ1c9n2A8zYBLVfgs1 Lj06+9hA4hLzbRwBdgPNK2YH+KXHW/Uf/yVM2/dGnaUaPiM2iCmzbbv7APJ0aCjCZjDAbqLog 1MLTbtOCAlGYb9Pp6TxO3AtTNNeUpRfHoSx4437gT+0rX8SSiW6gEOnQt33PXVTAQm62w1eG/ +2i2ArpSprLnd82kTukkOWqu1mRh3jryjZ9nq0NYM22kOQm79zhk4hhc4YXymV9QAjkwnkjD5 9ENyxyzx2KekbdQdckLWmYn4qHRytS2cVmrO1aMSetlPNYzqMz/RLbab+vBM6Lico9UmuIRG3 t8lcLvbJOpTjAYmXjUgx8WMiG/Y9e0lv9tfdqPLss0PyL2aBNXVQdUSaUskUtDoSyPg0Xwlae wTti1KiHWLUhjaEzv14gmMF6A9qyJQXPbd21j/cdUqg0wE4M0UOiAr0q4hpBoDyOzkxdGmtx6 +PEBcqbDucg3YRT8HLddZmUx184gN93KJsumJZIkEFHxXV1wV9baTamz5jnzEYjMCQtvUFLxC iIq7THE+agmdGtk7h8SDM2RuyEkfBaAgSDG1yItbLhMIttzhGWGofN/XM/XfS+XEsLUmbK2QU zOe5gkSvEjipbdYuGKtJ/kqkLdktEyp5ijFhuiDCFNPEr3WLcdprFDSjybRmOKXNGoAjTuoj5 E6kQyY1xKiGfyMkLuiZojY1GoC08alskjbu5SxJZdd1RZvJuAtJYW4ePPny3SGzHj9jt8oW3f PDNB2wYKr1IH55PjQnyxQAIYAdKsG/C7YYZ8o1iW6K9a7XLOPY2d4nSsBWdBbC2L8eDc5Sko3 ssdjS93HLefM5RMjzi9KhZmDkPU13Tda+kBqF52Na3hzfNmC9pqioLETDpcP7zFGvha2zrCmu EU6AyTrDjQcV58wXh7GaEifTJkh9tUKjc7zPwzxtcVAj98OjOUQsscIpObmMUsIutGzyCZUJm ViUwV/Dp68bAG/iyL3yS4VPwv8DlEomT918+03ATqmciYzQvs3gZjAPI7aJIQ0JRxaUeJS1WV 7jIKQw4/vV8SKFk8wJQN/Ni2oi/0TTFj5DRFm3RheAmYmJT+WaiFtInwjgeHyE9EG3Pf2Jan7 PiXfFTvfBGCZEdztKc3KH3gJezU8dizBE3vv+bm4HibJSYhJ/qovSCVYNbIPbgeIuLEIN+U8b zHvBvgQ70rmM2Hx2pBZLEFYD8MxrwNy/gwEjJ8wtcXpsaxnOP+A5rRoiHBXPP+UJnZ//jknYA bv9aVl5+ZVXYovMBG6NK/gvamXFICSlwDLUG51LqieS2D6TAWcx0US9MKHMwrQFsTHa9YPWPs wEjvzui8NnTfH5WlfLMghi7ngpEmrONdA/Z1nzxFuM2I4xGVeE4ZDM2idfQu8xAtq/6nc3/AA OUjZBY2ZH9IF2//Kc5ghv0gLOKsFoN7IEParsfrbb7NT3GBVKAoBR/e39veRf1gcOpmhL0MMf qOMBAqUOAsgYjXtg+dY/Ukr04KnlmdEOD0Lu8Q6AAmSeSAyZbFXC5hvv/F0URQTFi8ebpIrk6 xm7yKZuKnJiG/rhiZL3i6SUEIQgECV1rDTJKvXyAmQXB9V7x6ltMD6j20Qb5PT9sJvb+JBSoE 7IQjIiXfoY5N9FLbDITjF+gCJxbBWg+XiPDyrW5yFRX+AnuowylRsumMfkAoJrTRJQt1rt5cd f7h+4j1x70f69LFS9d56NqWiEF7rQLNmDxo+swSVsESfpLdVSzie7vML7cqFqmgpOnRXJId9i 63/6AlhEfuDJg0LhI56pdFG5rXp9J+meYZmnGKyVl+kN7LF5402OTrrDk9p+tUgFTjYjnnb+W 1N61u8zHWPFxXNUZOj07V5W03oapw6Cb6luIqZwnQ+P70uGpBdQd/6pPRERSuKClp2/Xsy59Y XJO/JeLqhgLd2At9yu2pBitcwauJKfQq+FLVzTxcgK6N/f7WpofzpHB65eBKPSDalnTOREMqR jWEoWpSUCl+nXW/Ccr6vJCfrSFUglpvhAnYlnw1F66l+mZK6Vt2bZPlykiQtADbxqigUNzQYS QhPH4A0oa+1nob2t16/ZepxNryaQjsMk3clFa7Q9Szb9FO9CSRJbOiXTql8aLTSw0CnQXy7Qv B+kXIh1koOaivbQmSvJqkco226GCBeAFwRiHd/REnuAalyXgkqgxRe8Z0gg5zbBBgQ6ul0TQs PmzIdRdDZgvlKsyZ70QJvLOB9te7CzVS+mIPrJFYeWmBI5Fb2zlwJ1IpdxdJRAwzYRUH0loWG xqi8Dc0tYIhi2w03HF9v5UeHXbXAe7I8TgH+Zj2rLIsAPh0PK7jOin8nNwLbx7/ibmaGJV89w J4/gTdSVgVjdYTzYhvVyAKmDI2PTB81PJBtSQTYeHXGRwBuHtDIzfRlDnV1GYVtobbgiEFMlr GNpvUZZqWbn8t/IFoXJ09I0DxBn2cdRLquxeV4Jzg/u61aEpGsSx+J12HIkbzovQLSdt9veVT Um44mYnj25ScVh8DYvqOkXPdeq5odou4L+2BtZU7RnutT5CjGjPXN57Vfq8HrYYjVQ36+TQeS yYxYN76KlOWplXJ5OIt8/rb2kEjtJtKznxg3rpTTU/2jVsvkphQZu2ymMbbfQ1oMngCFca2t5 5mVRi6LKnNJiMVxYzF0iKtodhklCPoOOsKhfJTIJb8r0BNSy6nA9s8hVYYwn+lMhD1yF6A72o XhUW9cmui1p2Knf8HjzzdR1/DoBVdMOpBj5/8Ep1rhIvb22Sv4CQWaPC9mu/Sv/lus2THCjNO 7XmF2yCsxmA/vk/6SepTnTWitFrTY2sODnfbemurbGKeT+hcKSXFOtyN0s1XuoECu2jAv3Se6 RWkNHxwmXLbFikzzB6tCjesaFjZoJR19d4OSYfsX0SjkLv5l6PPKN5Mypw/Wax7OhAQFgv7AS 4bqxJnJcWHm44MiCy8ZdWWUFBvKFo7N6M6guUjom18FeFuJRmyeMcQXf177g6uunzMrWALN7A s9t5pK3PJSDnKehUt3Be8yFirAff+cA96/DXymiHEFgT0Ho70ZrUSF4pXOPj/GIvxYT1URqcT fXsD5lQy79E1iyAF/BYBj8SW8aJgs4W51HoR61GLVNkouyOzeZ2aEot6vHOUnXi4A82dCPxMr gqIF0uG0KUhNgMshTXjgHG2g8n/kcLFW+HBQI1TS3NrT9bnF2s++Po3NH+sFtlZnViH00URfN uAMYREq3qCopIPiEqj//+UqiHMqzT3FV3U80m0BCWn0rWJz8diRNoTkdozolSc3WyuAHFgf8S 84LmNpgqcfP8nUicgoqTTHxHLKcJdoPqrT4ogG+WtZMZzy3GPp8R+ycTe3IBFA2TcoKidUDS9 apEL+t0MECbPeALaFnuTLQG4uVAU4EY0n5hPY8CdzOJgKUjlNoGCs9DpBiY1MA05yJ/A7yeoD k1g8R5dJ5QFZWmuZUl+eMRPn7Py3EN/naoEQwxsqtKDd6Xzit5cHDU8cdVsYYb1VSNknHdePl l9HBajVVyf4uPC6DhXfHkLSkG7u7UPhb2RWizzWUyDwnTtcDiNmAKTyHw7c5aIfy6TnMwrNgV LcC77oUDjlDa32DY96FziHxWTi+k9EW3wDH+KLtzJ8U4QrhNKxzkLTrSLWkrJsEeieMkh2aWh 574U2DEk4OzO1M/7NIi4BUPp88bn3INarWZf6q32dtvKaIRCWVL+hkJaQ1tm41YJM5O7lQCKL crhZsTYD45mNN1xB484iA/HM4P4cL6+h5l9QYb+bPpBobSEBnHm2Yv8206HU3Ze6DlkgCkttC VpK41i3PsZHzkCIRPyL2neCNyEZU74qlgnLDcSsxj3y+evF4VssErJN+QgNWEsWEUltA3OTwp dl1GQXG5Q4zAsA/JWZRfu907UUkT87LevF9Emepmp4dhqA55TPzeOTHvyd6HmpY0A5oXbsZcN deBPh/1GAIxXa93j8cztSQ0HTopqusWcEfynWhL8ZDzaZLg4NPpjEkhNAGmcyKukSkagfjotN Ss0gXKcgsguaxy1fFkcZEtRZjIRLhJN3eKsdVq+RtBV0+EMBesytSx66NX96Ckn7Zq3uYljoz /wM8oa2lSZpQcIbp6+Ef/cCqvHz6yvb7wAjKoNwy+tAUoWa1g1ywFTwdSMQNRZJvdfecjwnE1 RloJ6fE4tVfj55pfMF6TPOBn9UYsMPii8omLTwxV/bI517ozsfWlV3t2KIHphw0W9U2UPWIBK FV9qF4/A== =E2=80=A6 > Declare the looked-up device with __free(pci_dev_put), so the temporary > reference is released on every return path. Keeping the reference scoped > to the whole probe also covers all later uses of the device during > initialization. =E2=80=A6 Is there a need to reduce the scope for such a local variable further by using a corresponding compound statement? Regards, Markus