From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com
Subject: Re: [RFC PATCH 0/6] qapi: Preliminary work for better QOM introspection
Date: Tue, 13 Oct 2026 15:57:16 +0200 [thread overview]
Message-ID: <871p9tya83.fsf@pond.sub.org> (raw)
In-Reply-To: <CAJ+F1CKqDbV0xVkL6Q_++qHk4iNstWC_y2raPXy8BovUyPQzdQ@mail.gmail.com> ("Marc-André Lureau"'s message of "Fri, 9 Oct 2026 18:57:54 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Hi Markus
>
> On Fri, Oct 9, 2026 at 6:05 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Marc-André Lureau has patches to improve QOM introspection. Latest
>> version is
>>
>> Subject: [PATCH v5 00/62] qom/qdev: associate properties with QAPI schema types
>> Date: Fri, 11 Sep 2026 20:34:34 +0400
>> Message-Id: <20260911-qom-qapi-v5-0-7732a55b7760@redhat.com>
>> https://lore.kernel.org/qemu-devel/20260911-qom-qapi-v5-0-7732a55b7760@redhat.com/
>>
>> The first few patches make the QAPI code generator emit type
>> information for use by QOM introspection commands. They refactor code
>> to gain access to masked type names, and to make query-qmp-schema not
>> elide types QOM introspection might want to refer to.
>>
>> My series does this in a different way I find simpler. It is RFC
>> because merging it only makes sense if Marc-André finds it useful.
>> Marc-André, please have a look.
>
> This is essentially doing the same introspection changes but at a
> different level. If you ask me, since it's essentially code cleanup at
> this point, I would rather merge my changes first and iterate on top.
> But you are the gate keeper, so I wouldn't hold it, we need to move
> on... I can rebase on top of your refactoring if you prefer.
A rebase gives me a cleaner git history, which I like. Asking you to do
it feels a bit unfair, so I did it:
https://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qom-props-qapi-types-v5-rebased
I had to change "qapi: add type-infos generator" quite a bit (commit
465ae98da2). Slightly simpler now.
I resolved a rebase conflict in "qom: convert scalar properties to
QAPI-aware registration".
I dropped "qapi: expose integer signedness and width in introspection"
because I don't agree with it, and couldn't be bothered to resolve the
conflict (iirc).
I dropped "qapi: select introspectable types directly", because it's not
needed anymore.
next prev parent reply other threads:[~2026-10-13 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:04 [RFC PATCH 0/6] qapi: Preliminary work for better QOM introspection Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 1/6] qapi/schema: Rename .lookup_entity() and tighten return type Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 2/6] qapi: Ease access to introspection names Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 3/6] qapi/introspect: Simplify masked name comment emission slighly Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 4/6] qapi/introspect: Don't elide types Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 5/6] qapi: QAPISchemaVisitor.visit_needed() is now unused, drop Markus Armbruster
2026-10-09 14:04 ` [RFC PATCH 6/6] qapi/introspect: Tweak integer type masking Markus Armbruster
2026-10-09 14:57 ` [RFC PATCH 0/6] qapi: Preliminary work for better QOM introspection Marc-André Lureau
2026-10-13 13:57 ` Markus Armbruster [this message]
2026-10-13 15:20 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871p9tya83.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.