Re: [PATCH] phy: phy-mtk-hdmi: add new driver

[Mattijs Korpershoek via U-Boot <u-boot@lists.u-boot-project.org>]

Hi Julien,

Thank you for the patch.

On Fri, Jul 17, 2026 at 10:26, Julien Stephan <jstephan@baylibre.com> wrote:

> Add a new driver for the HDMI PHY. The driver supports MT8188 and MT8195
> based SoCs. The driver is based on the corresponding kernel driver.

What kernel version (exact commit, including the sha) has this been
ported from ?

Mentioning it in the commit message will help reviewers to compare this
with the linux codebase.

I can do a more detailed review once I know the linux base this has been
ported from.

>
> Signed-off-by: Pavlo Yadvychuk <pyadvychuk@baylibre.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---

[...]

> +
> +	/* RG_HDMITXPLL_RESERVE[12:11] */
> +	mtk_hdmi_phy_mask(hdmi_phy, HDMI_1_PLL_CFG_1,
> +			  0x3 << RG_HDMITXPLL_RESERVE_BIT12_11_SHIFT,
> +			  RG_HDMITXPLL_RESERVE_BIT12_11);
> +
> +	/* TCL_EN */
> +	mtk_hdmi_phy_mask(hdmi_phy, HDMI_1_PLL_CFG_0,
> +			  0x1 << RG_HDMITXPLL_TCL_EN_SHIFT,
> +			  RG_HDMITXPLL_TCL_EN);
> +
> +	/* we should always read calibration impedance
> +	 * from efuse, unless for debugging purposes.
> +	 * This calibraion value is not board-dependent

calibraion -> calibration

> +	 * so no SW adjustment required.
> +	 */
> +	if (hdmi_phy->conf->efuse_sw_mode) {
> +		debug("efuse_sw_mode ENABLED!!!");
> +		mtk_hdmi_phy_mask(hdmi_phy, HDMI_CTL_1,
> +				  0x1f << RG_INTR_IMP_RG_MODE_SHIFT,
> +				  RG_INTR_IMP_RG_MODE);
> +	}
> +
> +	return 0;
> +}
> +

[...]