All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE`
Date: Wed, 15 Jul 2026 14:28:20 +0200	[thread overview]
Message-ID: <871pd4h1y3.fsf@emacs.iotcl.com> (raw)
In-Reply-To: <20260715-pks-refs-wo-the-repository-v2-2-d00d364f5a3e@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> There's a single user of `the_repository` in the "packed" reference
> backend. Convert it to instead use the backend's repository and drop
> `USE_THE_REPOSITORY_VARIABLE`.

Well, this was removed in the previous patch. I'm fine keeping this as a
separate commmit, but the messaging is a bit confusing.

>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  refs/packed-backend.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/refs/packed-backend.c b/refs/packed-backend.c
> index 14b27d24ec..c5d96793fa 100644
> --- a/refs/packed-backend.c
> +++ b/refs/packed-backend.c
> @@ -1,4 +1,3 @@
> -#define USE_THE_REPOSITORY_VARIABLE
>  #define DISABLE_SIGN_COMPARE_WARNINGS
>  
>  #include "../git-compat-util.h"
>
> -- 
> 2.55.0.313.g8d093f411d.dirty
>
>

-- 
Cheers,
Toon

  reply	other threads:[~2026-07-15 12:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  8:29 [PATCH 0/7] refs: remove use of `the_repository` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-09 18:52   ` Junio C Hamano
2026-07-10  5:56     ` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 3/7] refs/files: " Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-09 20:39 ` [PATCH 0/7] refs: remove use " Junio C Hamano
2026-07-10  5:56   ` Patrick Steinhardt
2026-07-10  6:14     ` Patrick Steinhardt
2026-07-10 16:57       ` Junio C Hamano
2026-07-10 20:24         ` Junio C Hamano
2026-07-10 14:48     ` Junio C Hamano
2026-07-15  7:39 ` [PATCH v2 " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-15 12:28     ` Toon Claes [this message]
2026-07-15  7:39   ` [PATCH v2 3/7] refs/files: " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-15 12:31   ` [PATCH v2 0/7] refs: remove use " Toon Claes
2026-07-15 14:38     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pd4h1y3.fsf@emacs.iotcl.com \
    --to=toon@iotcl.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.