From: Takashi Iwai <tiwai@suse.de>
To: Harin Lee <me@harin.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Maarten Lankhorst <m.b.lankhorst@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Limit PTP to a single page
Date: Mon, 06 Apr 2026 10:50:44 +0200 [thread overview]
Message-ID: <871pgsmpzv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260406074857.216034-1-me@harin.net>
On Mon, 06 Apr 2026 09:48:57 +0200,
Harin Lee wrote:
>
> Commit 391e69143d0a increased CT_PTP_NUM from 1 to 4 to support 256
> playback streams, but the additional pages are not used by the card
> correctly. The CT20K2 hardware already has multiple VMEM_PTPAL
> registers, but using them separately would require refactoring the
> entire virtual memory allocation logic.
>
> ct_vm_map() always uses PTEs in vm->ptp[0].area regardless of
> CT_PTP_NUM. On AMD64 systems, a single PTP covers 512 PTEs (2M). When
> aggregate memory allocations exceed this limit, ct_vm_map() tries to
> access beyond the allocated space and causes a page fault:
>
> BUG: unable to handle page fault for address: ffffd4ae8a10a000
> Oops: Oops: 0002 [#1] SMP PTI
> RIP: 0010:ct_vm_map+0x17c/0x280 [snd_ctxfi]
> Call Trace:
> atc_pcm_playback_prepare+0x225/0x3b0
> ct_pcm_playback_prepare+0x38/0x60
> snd_pcm_do_prepare+0x2f/0x50
> snd_pcm_action_single+0x36/0x90
> snd_pcm_action_nonatomic+0xbf/0xd0
> snd_pcm_ioctl+0x28/0x40
> __x64_sys_ioctl+0x97/0xe0
> do_syscall_64+0x81/0x610
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
>
> Revert CT_PTP_NUM to 1. The 256 SRC_RESOURCE_NUM and playback_count
> remain unchanged.
>
> Fixes: 391e69143d0a ("ALSA: ctxfi: Bump playback substreams to 256")
> Cc: stable@vger.kernel.org
> Signed-off-by: Harin Lee <me@harin.net>
Applied to for-next branch now, as it's no regression in 7.0, per se.
But, I wonder whether fixing in ctvmem.c would be relatively easy.
Isn't it only about ct_vm_map() and ct_get_ptp_phys()?
thanks,
Takashi
next prev parent reply other threads:[~2026-04-06 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 7:48 [PATCH] ALSA: ctxfi: Limit PTP to a single page Harin Lee
2026-04-06 8:50 ` Takashi Iwai [this message]
2026-04-06 10:32 ` Harin Lee
2026-04-07 13:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pgsmpzv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=me@harin.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.