From: "Alex Bennée" <alex.bennee@linaro.org>
To: Florian Hofhammer <florian.hofhammer@epfl.ch>
Cc: qemu-devel@nongnu.org, Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH v7 1/8] plugins/core: clamp syscall arguments if target is 32-bit
Date: Thu, 05 Mar 2026 17:26:34 +0000 [thread overview]
Message-ID: <871phynq5x.fsf@draig.linaro.org> (raw)
In-Reply-To: <20260305-setpc-v5-v7-1-4c3adba52403@epfl.ch> (Florian Hofhammer's message of "Thu, 5 Mar 2026 11:05:59 +0100")
Florian Hofhammer <florian.hofhammer@epfl.ch> writes:
> From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>
> Syscall arguments are abi_long in user code, and plugin syscall
> interface works with uint64_t only.
>
> According to C integer promotion rules, the value is sign extended
> before becoming unsigned, thus setting high bits when only 32-bit lower
> ones should have a significant value.
>
> As a result, we need to clamp values we receive from user-code
> accordingly.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2026-03-05 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 10:05 [PATCH v7 0/8] Enable PC diversion via the plugin API Florian Hofhammer
2026-03-05 10:05 ` [PATCH v7 1/8] plugins/core: clamp syscall arguments if target is 32-bit Florian Hofhammer
2026-03-05 16:09 ` Pierrick Bouvier
2026-03-05 17:26 ` Alex Bennée [this message]
2026-03-05 17:33 ` Philippe Mathieu-Daudé
2026-03-05 17:38 ` Pierrick Bouvier
2026-03-06 7:46 ` Florian Hofhammer
2026-03-06 17:46 ` Pierrick Bouvier
2026-03-05 18:23 ` Pierrick Bouvier
2026-03-05 10:06 ` [PATCH v7 2/8] plugins: add flag to specify whether PC is rw Florian Hofhammer
2026-03-05 10:06 ` [PATCH v7 3/8] linux-user: make syscall emulation interruptible Florian Hofhammer
2026-03-05 10:06 ` [PATCH v7 4/8] plugins: add PC diversion API function Florian Hofhammer
2026-03-05 10:06 ` [PATCH v7 5/8] tests/tcg: add tests for qemu_plugin_set_pc API Florian Hofhammer
2026-03-05 18:24 ` Pierrick Bouvier
2026-03-05 10:06 ` [PATCH v7 6/8] plugins: add read-only property for registers Florian Hofhammer
2026-03-05 10:06 ` [PATCH v7 7/8] plugins: prohibit writing to read-only registers Florian Hofhammer
2026-03-05 10:06 ` [PATCH v7 8/8] tests/tcg/plugins: test register accesses Florian Hofhammer
2026-03-06 17:44 ` [PATCH v7 0/8] Enable PC diversion via the plugin API Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871phynq5x.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=florian.hofhammer@epfl.ch \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.