All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Yuwen Chen <ywen.chen@foxmail.com>,
	bigeasy@linutronix.de, wakel@google.com
Cc: andrealmeid@igalia.com, colin.i.king@gmail.com,
	dave@stgolabs.net, dvhart@infradead.org, edliaw@google.com,
	justinstitt@google.com, kernel-team@android.com,
	licayy@foxmail.com, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, luto@mit.edu, mingo@redhat.com,
	morbo@google.com, nathan@kernel.org, ndesaulniers@google.com,
	peterz@infradead.org, shuah@kernel.org,
	usama.anjum@collabora.com, Yuwen Chen <ywen.chen@foxmail.com>
Subject: Re: [PATCH] selftests/futex: fix incorrect result reporting of futex_requeue test item
Date: Tue, 27 Jan 2026 19:35:19 +0100	[thread overview]
Message-ID: <871pjac3a0.ffs@tglx> (raw)
In-Reply-To: <tencent_56D79AF3D23CEFAF882E83A2196EC1F12107@qq.com>

On Tue, Jan 27 2026 at 15:37, Yuwen Chen wrote:
> When using the TEST_HARNESS_MAIN macro definition to declare the main
> function, you need to use the EXPECT_ and ASSERT_ series of functions in
> conjunction. Otherwise, even if a test item fails, the test will still
> return a success result.
>
> When adding a delay in waiterfn to artificially create an incorrect test
> result, the test item has actually failed. However, the output still
> indicates that the test has passed:

This is an actual fix and wants to go _before_ adding hacks to solve the
my system is too busy to start a thread in 10 seconds "problem".

Thanks,

        tglx

  reply	other threads:[~2026-01-27 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27  7:37 [PATCH] selftests/futex: fix incorrect result reporting of futex_requeue test item Yuwen Chen
2026-01-27 18:35 ` Thomas Gleixner [this message]
2026-01-28  2:09   ` Yuwen Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pjac3a0.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=andrealmeid@igalia.com \
    --cc=bigeasy@linutronix.de \
    --cc=colin.i.king@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=edliaw@google.com \
    --cc=justinstitt@google.com \
    --cc=kernel-team@android.com \
    --cc=licayy@foxmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    --cc=wakel@google.com \
    --cc=ywen.chen@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.