From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF175CCF9F8 for ; Wed, 12 Nov 2025 13:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gAA1I5XCicVVXzsCaU6T85AbRGETuB7fW7RNSmrNCiE=; b=urMbl2O2M8fzwy 3h/NqNuxDa42SNOsHvTCo0v40g64pyfsujLNHSM+Nsr+z8x6ZNdWh/Qo/apwxDhi+CamJSzk7ifwQ mHQV78WtF/BaABkcvxAo16Myv4idWO04IISuCwYi9pf8gGOzo87oYVgf6yr95epJTxC4AkdXR+n7x dc0vcXgZrU2LN1/Kte0wVt41/1uPdzAlA+zibY69XX+Su+FADPjC43S8ONay0UA3JnPYRH6DpVUsr AGBMsnkqehZxkiDI8vbnPWDHTkpJ8bYcoeRaniVtFAZWHWNLAEYwjikANgyHD24HYdgIzjvN4GZZH 847srk6B3/1spMSd+WzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJAcb-00000008p13-0wd5; Wed, 12 Nov 2025 13:10:49 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJAcY-00000008p0a-40Bc for linux-mtd@lists.infradead.org; Wed, 12 Nov 2025 13:10:48 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 4F0D0C0F556; Wed, 12 Nov 2025 13:10:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E40A36070B; Wed, 12 Nov 2025 13:10:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6D8E1102F16E2; Wed, 12 Nov 2025 14:10:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762953044; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8FxSJ1YhSz/uKUxjGqRnSA5I1+h/hTb/Q5Ve6fg5lws=; b=kUSxogklGuF/0uxGORVdT5LTnPw+kZ0d587IfLv40DmGK4Z+lBtSNKY2kGsYL7NAZNn9GE T7DSGjkge483ANaLMiKbiIuGXV832f/B9VYsBmLgik+84PP9epSZm3NVJ2vsryC6L+Jz5U sKIRhlgfBjP78+Xl3RGF0C8dSMoh5eRIqRUGLYLRSlcoO0xXN/9WCvp7g2DlIaTg0UC/GY Jxivb3R41K5nCtbxNZWqXdmXFrHbEk1Ua5iH8AUPlrhMzi/xJ7GdS87upeh0vwkpEtmMWP dbbVSitm57RO0F6D5eG5Sqj4yHEKf+8a2akWSQ/Sh+EKy0LrYBUj0V4hCOqjLw== From: Miquel Raynal To: Sean Anderson Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Richard Weinberger , linux-kernel@vger.kernel.org, Vignesh Raghavendra Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q00a In-Reply-To: <92e99a96-5582-48a5-a4f9-e9b33fcff171@linux.dev> (Sean Anderson's message of "Tue, 14 Oct 2025 14:25:10 -0400") References: <20251006223409.3475001-1-sean.anderson@linux.dev> <4888cefa-e8be-4f0d-9d4a-c82f9ff6cda0@linux.dev> <26a795ac-e6ff-4363-a8b9-38793a9be794@linux.dev> <33cbbac1-c247-4644-b555-998eea6e8305@linaro.org> <92e99a96-5582-48a5-a4f9-e9b33fcff171@linux.dev> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 12 Nov 2025 14:10:40 +0100 Message-ID: <871pm3iegf.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_051047_150377_73FA1052 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gU2VhbiwKCj4gIyBmbGFzaF9sb2NrIC11IC9kZXYvbXRkL2J5LW5hbWUvc3BpMC4xCj4g IyBmbGFzaF9sb2NrIC1pIC9kZXYvbXRkL2J5LW5hbWUvc3BpMC4xCj4gRGV2aWNlOiAvZGV2L210 ZC9ieS1uYW1lL3NwaTAuMQo+IFN0YXJ0OiAwCj4gTGVuOiAweDgwMDAwMDAKPiBMb2NrIHN0YXR1 czogdW5sb2NrZWQKPiBSZXR1cm4gY29kZTogMAo+ICMgdGVzdCgpIHsKPj4gbXRkPS9kZXYvbXRk L2J5LW5hbWUvJDEKPj4gc3RhcnQ9JCgoJDIgKiA2NCAqIDEwMjQpKQo+PiBzaXplPSQoKCQzICog NjQgKiAxMDI0KSkKPj4gZGQgaWY9L2Rldi91cmFuZG9tIG9mPSQxIGJzPTY0ayBjb3VudD0kMyBz dGF0dXM9bm9uZSAmJiBcCj4+IG10ZF9kZWJ1ZyBlcmFzZSAkbXRkICRzdGFydCAkc2l6ZSAmJiBc Cj4+IG10ZF9kZWJ1ZyB3cml0ZSAkbXRkICRzdGFydCAkc2l6ZSAkMSAmJiBcCj4+IGRkIGlmPSRt dGQgYnM9NjRrIHNraXA9JDIgY291bnQ9JDMgc3RhdHVzPW5vbmUgfCBzaGEyNTZzdW0gJDEgLSAm JiBcCj4+IHJtICQxCj4+IH0KCkkgYW0gYWxzbyB3b3JraW5nIG9uIGxvY2tpbmcgdGhlc2UgZGF5 cywgaGF2ZSB5b3UgYWxyZWFkeSBzdGFydGVkCndyaXRpbmcgZXh0cmEgU1BJIE5PUiBEb2N1bWVu dGF0aW9uL3Byb2Nlc3MgYmFzZWQgb24gdGhpcyB0aHJlYWQ/CgpJIGFtIGFsc28gdHJ5aW5nIHRv IGNsYXJpZnkgd2hhdCBpcyBleHBlY3RlZCBhbmQgd2hhdCB0aGUgQVBJIHNvbWVob3cKZG9lcywg YXMgaXQgd2FzIG5vdCBmdWxseSBjbGVhciBmb3IgbWUgYXQgZmlyc3Qgc2lnaHQuCgpbLi4uXQoK PiAjIGZsYXNoX2xvY2sgLXUgL2Rldi9tdGQvYnktbmFtZS9zcGkwLjEKPiAjIHRlc3Qgc3BpMC4x IDY0Cj4gODNhOGRjNjEyNWVjOTY3MmQxOGY3ZjE4ZjkyZTE2Zjg2NzM1NGRiZThlMmYzYjBhY2E1 MmI5ZDBhZDdkOGZmZSAgc3BpMC4xCj4gODNhOGRjNjEyNWVjOTY3MmQxOGY3ZjE4ZjkyZTE2Zjg2 NzM1NGRiZThlMmYzYjBhY2E1MmI5ZDBhZDdkOGZmZSAgLQo+ICMgZmxhc2hfbG9jayAtbCAvZGV2 L210ZC9ieS1uYW1lL3NwaTAuMSAkKCgxMDI0ICogNjQgKiAxMDI0KSkgMTAyNAo+ICMgZmxhc2hf bG9jayAtaSAvZGV2L210ZC9ieS1uYW1lL3NwaTAuMSAKPiBEZXZpY2U6IC9kZXYvbXRkL2J5LW5h bWUvc3BpMC4xCj4gU3RhcnQ6IDAKPiBMZW46IDB4ODAwMDAwMAo+IExvY2sgc3RhdHVzOiB1bmxv Y2tlZCA8PDw8IFdyb25nIQoKVGhpcyBpc24ndCB3cm9uZywgZXZlbiB0aG91Z2ggYXQgYSBmaXJz dCBnbGFuY2UgdGhlIG91dHB1dCBpcwptaXNsZWFkaW5nLiBUaGUgQVBJIGFwcGFyZW50bHkgZG9l cyBub3QgZ2l2ZXMgeW91IGFsbCB0aGUKbG9ja2VkL3VubG9ja2VkIHNlY3RvcnMsIGl0IGlzIHdh eSBtb3JlIGJhc2ljIHRoYW4gdGhhdDogaXQgdGVsbHMgeW91CndoZXRoZXIgdGhlIGZ1bGwgcmFu Z2UgeW91IGFza2VkIGZvciBpcyBpbmRlZWQgbG9ja2VkLgoKV2hlbiB5b3UgcnVuICIjIGZsYXNo X2xvY2sgLWkgL2Rldi9tdGQvYnktbmFtZS9zcGkwLjEiLCB5b3UgcHJpdmlkZSBubwpzdGFydC9s ZW5ndGggdmFsdWVzIHRvIHRoZSBjb21tYW5kLiBIZW5jZSwgdGhlIGRlZmF1bHRzIGFyZSBwaWNr ZWQ6IHRoZQplbnRpcmUgZGV2aWNlIGlzIGNvbnNpZGVyZWQgZm9yIHRoZSBjaGVjay4gVGhlIHRv b2wgYXNrcyB0aGUga2VybmVsCndoZXRoZXIgdGhlIHJhbmdlIDAtMHg3ZmZmZmZmIGlzICpmdWxs eSogbG9ja2VkLiBBbnN3ZXIgaXMgbm8sIGl0IGlzIG5vdApmdWxseSBsb2NrZWQuCgpJbiB0aGUg a2VybmVsIHRoZXJlIGFyZSB0d28gaGVscGVycyBmb3IgdGhhdCwgYW5kIHRoZXkgd29uJ3QgZ2l2 ZSB5b3UKb3Bwb3NpdGUgcmVzdWx0cyBhbGwgdGhlIHRpbWU6Ci0gaXMgbG9ja2VkOgogICAgLSBy ZXR1cm5zIHRydWUgaWYgdGhlIGdpdmVuIHJhbmdlIGlzIGZ1bGx5IGxvY2tlZAogICAgLSByZXR1 cm5zIGZhbHNlIG90aGVyd2lzZQotIGlzIHVubG9ja2VkOgogICAgLSByZXR1cm5zIHllcyBpZiB0 aGUgZ2l2ZW4gcmFuZ2UgaXMgZnVsbHkgdW5sb2NrZWQKICAgIC0gcmV0dXJucyBmYWxzZSBvdGhl cndpc2UKClNvIGlmIHlvdSB3YW50IHRoZSB0b29sIHRvIHRlbGwgeW91ICJ5ZXMiLCB5b3Ugc2hv dWxkIGluc3RlYWQgdXNlIHRoZQpleGFjdCByYW5nZSB5b3UgbG9ja2VkICgxMDI0LTIwNDcpIG9y IGFueSBzdWJzZXQgb2YgaXQuCgpUaGFua3MsIE1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B8131196C for ; Wed, 12 Nov 2025 13:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762953048; cv=none; b=au6GbzhnCWy2Q+AepGAcca+4xHTREiwou3qWcLwVJKA/k1Nte+bgjntfRO0qwVRfMozW2h/GxnZ0ZoLQKJX/3jBMxyfXNHb+XGx/JSn4BeX++kAd81cdyRxpmDrAJ1DLbcSNHplk5AM431nx2RN5SShzn2zP6WKMuhqncsLQb/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762953048; c=relaxed/simple; bh=2dGXt8VoW5CaG4YtnVqdqfl+eXlHLYQG2Tc1OSwxsg8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uKjAEBu7U2juwd7UWdsIgDCJBKmpUsKDVSo4mHsHAlBR+tZIyoPDRC2a7bu1E1OaZNSNiaZQwBZe462LAUgJWZD8USrwssb8m/Kx46db4KYF6VNcL4Znc5Ypq2bgvLooHrQzNZC0yAoeeBvihUmYwx0w9M3+9e9LA/II1CNIQdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=kUSxogkl; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="kUSxogkl" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 284F74E4163B; Wed, 12 Nov 2025 13:10:45 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E40A36070B; Wed, 12 Nov 2025 13:10:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6D8E1102F16E2; Wed, 12 Nov 2025 14:10:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762953044; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8FxSJ1YhSz/uKUxjGqRnSA5I1+h/hTb/Q5Ve6fg5lws=; b=kUSxogklGuF/0uxGORVdT5LTnPw+kZ0d587IfLv40DmGK4Z+lBtSNKY2kGsYL7NAZNn9GE T7DSGjkge483ANaLMiKbiIuGXV832f/B9VYsBmLgik+84PP9epSZm3NVJ2vsryC6L+Jz5U sKIRhlgfBjP78+Xl3RGF0C8dSMoh5eRIqRUGLYLRSlcoO0xXN/9WCvp7g2DlIaTg0UC/GY Jxivb3R41K5nCtbxNZWqXdmXFrHbEk1Ua5iH8AUPlrhMzi/xJ7GdS87upeh0vwkpEtmMWP dbbVSitm57RO0F6D5eG5Sqj4yHEKf+8a2akWSQ/Sh+EKy0LrYBUj0V4hCOqjLw== From: Miquel Raynal To: Sean Anderson Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Richard Weinberger , linux-kernel@vger.kernel.org, Vignesh Raghavendra Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q00a In-Reply-To: <92e99a96-5582-48a5-a4f9-e9b33fcff171@linux.dev> (Sean Anderson's message of "Tue, 14 Oct 2025 14:25:10 -0400") References: <20251006223409.3475001-1-sean.anderson@linux.dev> <4888cefa-e8be-4f0d-9d4a-c82f9ff6cda0@linux.dev> <26a795ac-e6ff-4363-a8b9-38793a9be794@linux.dev> <33cbbac1-c247-4644-b555-998eea6e8305@linaro.org> <92e99a96-5582-48a5-a4f9-e9b33fcff171@linux.dev> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 12 Nov 2025 14:10:40 +0100 Message-ID: <871pm3iegf.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Sean, > # flash_lock -u /dev/mtd/by-name/spi0.1 > # flash_lock -i /dev/mtd/by-name/spi0.1 > Device: /dev/mtd/by-name/spi0.1 > Start: 0 > Len: 0x8000000 > Lock status: unlocked > Return code: 0 > # test() { >> mtd=3D/dev/mtd/by-name/$1 >> start=3D$(($2 * 64 * 1024)) >> size=3D$(($3 * 64 * 1024)) >> dd if=3D/dev/urandom of=3D$1 bs=3D64k count=3D$3 status=3Dnone && \ >> mtd_debug erase $mtd $start $size && \ >> mtd_debug write $mtd $start $size $1 && \ >> dd if=3D$mtd bs=3D64k skip=3D$2 count=3D$3 status=3Dnone | sha256sum $1 = - && \ >> rm $1 >> } I am also working on locking these days, have you already started writing extra SPI NOR Documentation/process based on this thread? I am also trying to clarify what is expected and what the API somehow does, as it was not fully clear for me at first sight. [...] > # flash_lock -u /dev/mtd/by-name/spi0.1 > # test spi0.1 64 > 83a8dc6125ec9672d18f7f18f92e16f867354dbe8e2f3b0aca52b9d0ad7d8ffe spi0.1 > 83a8dc6125ec9672d18f7f18f92e16f867354dbe8e2f3b0aca52b9d0ad7d8ffe - > # flash_lock -l /dev/mtd/by-name/spi0.1 $((1024 * 64 * 1024)) 1024 > # flash_lock -i /dev/mtd/by-name/spi0.1=20 > Device: /dev/mtd/by-name/spi0.1 > Start: 0 > Len: 0x8000000 > Lock status: unlocked <<<< Wrong! This isn't wrong, even though at a first glance the output is misleading. The API apparently does not gives you all the locked/unlocked sectors, it is way more basic than that: it tells you whether the full range you asked for is indeed locked. When you run "# flash_lock -i /dev/mtd/by-name/spi0.1", you privide no start/length values to the command. Hence, the defaults are picked: the entire device is considered for the check. The tool asks the kernel whether the range 0-0x7ffffff is *fully* locked. Answer is no, it is not fully locked. In the kernel there are two helpers for that, and they won't give you opposite results all the time: - is locked: - returns true if the given range is fully locked - returns false otherwise - is unlocked: - returns yes if the given range is fully unlocked - returns false otherwise So if you want the tool to tell you "yes", you should instead use the exact range you locked (1024-2047) or any subset of it. Thanks, Miqu=C3=A8l