All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Haofeng Li <920484857@qq.com>, John Stultz <jstultz@google.com>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Haofeng Li <13266079573@163.com>,
	Haofeng Li <lihaofeng@kylinos.cn>
Subject: Re: [PATCH] timekeeping: Move debug sleep time accounting outside spinlock
Date: Tue, 09 Sep 2025 13:46:21 +0200	[thread overview]
Message-ID: <871pofx302.ffs@tglx> (raw)
In-Reply-To: <tencent_6FBD7FB2B5EDA57B1481766C52482D033008@qq.com>

On Tue, Sep 09 2025 at 18:23, Haofeng Li wrote:
> From: Haofeng Li <lihaofeng@kylinos.cn>
>
> The function tk_debug_account_sleep_time() was called inside a spinlock
> in __timekeeping_inject_sleeptime(), which could lead to potential
> deadlocks, particularly when CONFIG_DEBUG_PM_SLEEP is enabled.

How so exactly?

I don't see how that would deadlock, but I might miss something. So
please explain it properly instead of handwaving about it.

Thanks,

        tglx

  parent reply	other threads:[~2025-09-09 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 10:23 [PATCH] timekeeping: Move debug sleep time accounting outside spinlock Haofeng Li
2025-09-09 11:42 ` Thomas Gleixner
2025-09-09 11:46 ` Thomas Gleixner [this message]
2025-09-12 10:33   ` [PATCH WITHDRAWN] " Haofeng Li
2025-09-10  3:12 ` [PATCH] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pofx302.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=13266079573@163.com \
    --cc=920484857@qq.com \
    --cc=jstultz@google.com \
    --cc=lihaofeng@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.