From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B68B4CA0EDC for ; Thu, 14 Aug 2025 06:37:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D693860220; Thu, 14 Aug 2025 08:37:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D693860220 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1755153444; bh=+DYOQY+uj3RU1MSHwNncwHTuKO2M7KAOhucF4nWc1PI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JU4QDEmLbb1JEV/FaMbFUJZIUNYZaxyP1Zc9W5jBCSI8DZs1/5N6HRSIPxjFAgGi5 TU2nQV6BBg5ZSScaNV3BusnnqGbe+uRgg1HAAJIrOHvBOUhGtkbrHO7GTM2dL6X6Rh F5CG/uozsDlidUMLEDSEZ2WeHqEvFge+hmzRDN/s= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B62CF805C5; Thu, 14 Aug 2025 08:36:48 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 48D20F805D3; Thu, 14 Aug 2025 08:36:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F16D7F804CF; Thu, 14 Aug 2025 08:32:29 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 059DDF800B8 for ; Thu, 14 Aug 2025 08:32:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 059DDF800B8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L63H6Aof; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1tnHSWb1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=L63H6Aof; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1tnHSWb1 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7782221AAE; Thu, 14 Aug 2025 06:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755153139; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xu1qadWxTr+MAFIsiwJyhQ9AGjmxViERwRno/GWs84I=; b=L63H6AofurlzUFOb40yQoY3BvDHVDIZWuMbpXpui3p2PcXL1W+b4efTodOwYr2QDYEOcDK XzabqqwtIvAGF027+9uy/2O4d+SQ7kqMCQV1Sj80dl/DqgcXU6mPnj4uD4kRlDJxipyYnw MMCKZ79zgkrhb+EPlQSEx88WiCp4v98= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755153139; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xu1qadWxTr+MAFIsiwJyhQ9AGjmxViERwRno/GWs84I=; b=1tnHSWb1P0LkSBsunlgjf0dLxz6IrXOT8TWVIjPdN6i06myyxKiGj/I7TBWxJfk/j4JnG0 T4ROxIScLysISTAA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L63H6Aof; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1tnHSWb1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755153139; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xu1qadWxTr+MAFIsiwJyhQ9AGjmxViERwRno/GWs84I=; b=L63H6AofurlzUFOb40yQoY3BvDHVDIZWuMbpXpui3p2PcXL1W+b4efTodOwYr2QDYEOcDK XzabqqwtIvAGF027+9uy/2O4d+SQ7kqMCQV1Sj80dl/DqgcXU6mPnj4uD4kRlDJxipyYnw MMCKZ79zgkrhb+EPlQSEx88WiCp4v98= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755153139; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xu1qadWxTr+MAFIsiwJyhQ9AGjmxViERwRno/GWs84I=; b=1tnHSWb1P0LkSBsunlgjf0dLxz6IrXOT8TWVIjPdN6i06myyxKiGj/I7TBWxJfk/j4JnG0 T4ROxIScLysISTAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3D97B1368C; Thu, 14 Aug 2025 06:32:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Il8YDfOCnWivbAAAD6G6ig (envelope-from ); Thu, 14 Aug 2025 06:32:19 +0000 Date: Thu, 14 Aug 2025 08:32:18 +0200 Message-ID: <871ppewgzx.wl-tiwai@suse.de> From: Takashi Iwai To: "Xu, Baojun" Cc: "broonie@kernel.org" , "andriy.shevchenko@linux.intel.com" , "alsa-devel@alsa-project.org" , "Ding, Shenghao" , "13916275206@139.com" <13916275206@139.com>, "linux-sound@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name In-Reply-To: <417f8e1c8a314ae4a77070f313d8af2c@ti.com> References: <20250813100842.12224-1-baojun.xu@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; FREEMAIL_ENVRCPT(0.00)[139.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,linux.intel.com,alsa-project.org,ti.com,139.com,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 7782221AAE X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action Message-ID-Hash: 37BZMCH5HUV7QL6UMOXM7VRPYZQVEKRX X-Message-ID-Hash: 37BZMCH5HUV7QL6UMOXM7VRPYZQVEKRX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 14 Aug 2025 04:29:10 +0200, Xu, Baojun wrote: > > Hi, > > Answer in line. > > > ________________________________________ > > From: Takashi Iwai > > Sent: 13 August 2025 23:44 > > To: Xu, Baojun > > Cc: broonie@kernel.org; andriy.shevchenko@linux.intel.com; alsa-devel@alsa-project.org; Ding, Shenghao; 13916275206@139.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name > > > > On Wed, 13 Aug 2025 12:08:42 +0200, > > Baojun Xu wrote: > > > > > > Change the name of the kcontrol from "Gain" to "Volume". > > > > Could you describe "why this change is needed"? > > > This name is in kcontrol, which is open to users. > Volume is more normalized and common. > Gain is a more professional term in smart amplifiers. But did you realize that changing the control name may change the user-space behavior completely? e.g. alsa-lib implementation tries to group control elements per prefix and suffix, and "Volume" is one of the standard suffix. That is, with this change, it'll appear as "Speaker Analog" as a mixer element name where the former name is "Speaker Analog Gain". I'm not against the proposed rename. But please remember that control names aren't something you can change easily because you don't feel good; it's a thing to be more or less "fixed" once after defined in the release products. thanks, Takashi > > > > > thanks, > > > > Takashi > > > > > > > > Signed-off-by: Baojun Xu > > > --- > >> sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c > > > index 92aae19cfc8f..e4bc3bc756b0 100644 > > > --- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c > > > +++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c > > > @@ -256,7 +256,7 @@ static const struct snd_kcontrol_new tas2770_snd_controls[] = { > > > }; > > > > > > static const struct snd_kcontrol_new tas2781_snd_controls[] = { > > > - ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Gain", TAS2781_AMP_LEVEL, > > > + ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Volume", TAS2781_AMP_LEVEL, > > > 1, 0, 20, 0, tas2781_amp_getvol, > >> tas2781_amp_putvol, amp_vol_tlv), > > > ACARD_SINGLE_BOOL_EXT("Speaker Force Firmware Load", 0, > > > -- > > > 2.43.0 > > > > > > > > > Best Regards > Jim