From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees <kris.van.hees@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH 2/3] btf: do not try to generate CTF data if there is no BTF data
Date: Tue, 24 Jun 2025 15:16:32 +0100 [thread overview]
Message-ID: <871pr9ql6n.fsf@esperi.org.uk> (raw)
In-Reply-To: <SJ0PR10MB56728D3C877CA67B4504822AC279A@SJ0PR10MB5672.namprd10.prod.outlook.com> (Kris Van Hees's message of "Mon, 23 Jun 2025 19:37:19 -0400")
On 24 Jun 2025, Kris Van Hees outgrape:
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
modulo the spelling nit below.
> ---
> libdtrace/dt_module.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/libdtrace/dt_module.c b/libdtrace/dt_module.c
> index b3c8e247..eef5386a 100644
> --- a/libdtrace/dt_module.c
> +++ b/libdtrace/dt_module.c
> @@ -864,11 +864,12 @@ static void
> dt_kern_module_find_btf(dtrace_hdl_t *dtp, dt_module_t *dmp)
> {
> /*
> - * The first module for which we need to collect BTF data must be the
> - * 'vmlinux' module.
> + * If there is no shared BTF data, and we're trying to load BTF data
> + * fir any module other than "vmlinux", we can conclude no module has
s/fir/for/
--
NULL && (void)
prev parent reply other threads:[~2025-06-24 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 23:37 [PATCH 2/3] btf: do not try to generate CTF data if there is no BTF data Kris Van Hees
2025-06-24 14:16 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pr9ql6n.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.