From: Takashi Iwai <tiwai@suse.de>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<13564923607@139.com>, <13916275206@139.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<baojun.xu@ti.com>, <Baojun.Xu@fpt.com>, <jesse-ji@ti.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Fix the symbol was not declare warning reported by kernel test robot
Date: Tue, 13 May 2025 11:02:10 +0200 [thread overview]
Message-ID: <871pssubn1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250513071721.1090-1-shenghao-ding@ti.com>
On Tue, 13 May 2025 09:17:21 +0200,
Shenghao Ding wrote:
>
> After commit 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib
> to save the shared parts for both SPI and I2C driver") created a separated
> lib for both hda-i2c and hda-spi driver, which caused this issue.
> sparse warnings: (new ones prefixed by >>)
> >> sound/pci/hda/tas2781_hda_spi.c:496:25: sparse: sparse: symbol
> 'tas2781_snd_ctls' was not declared. Should it be static?
> >> sound/pci/hda/tas2781_hda_spi.c:505:25: sparse: sparse: symbol
> 'tas2781_prof_ctl' was not declared. Should it be static?
> >> sound/pci/hda/tas2781_hda_spi.c:512:25: sparse: sparse: symbol
> 'tas2781_dsp_ctls' was not declared. Should it be static?
>
> Fixes: 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib to save the shared parts for both SPI and I2C driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505130420.vr9yDI3k-lkp@intel.com/__;!!G3vK!URphGMMfZ2erCLfJdETofl0O1mTSydDLLJ6inMIYWYUDUKYef_IuLvI7pnYj3Mx-4LRIi4BJEw$
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-05-15 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 7:17 [PATCH v1] ALSA: hda/tas2781: Fix the symbol was not declare warning reported by kernel test robot Shenghao Ding
2025-05-13 9:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pssubn1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13564923607@139.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=jesse-ji@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shenghao-ding@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.