From: Axel Forsman <axfo@kvaser.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, mailhol.vincent@wanadoo.fr,
stable@vger.kernel.org, Jimmy Assarsson <extja@kvaser.com>
Subject: Re: [PATCH 1/3] can: kvaser_pciefd: Force IRQ edge in case of nested IRQ
Date: Tue, 08 Apr 2025 14:24:08 +0200 [thread overview]
Message-ID: <871pu296zb.fsf@kvaser.com> (raw)
In-Reply-To: <20250407-unyielding-panda-of-wealth-5c277e-mkl@pengutronix.de>
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 31.03.2025 09:25:26, Axel Forsman wrote:
>> -static u32 kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie)
>> +static void kvaser_pciefd_receive_irq(struct kvaser_pciefd *pcie)
>> {
>> + __le32 __iomem *srb_cmd_reg = KVASER_PCIEFD_SRB_ADDR(pcie) + KVASER_PCIEFD_SRB_CMD_REG;
>
> Why is this an __le32? The struct kvaser_pciefd::reg_base is __iomem
> void *.
Just as a hint that the register is 32-bit.
But you are right, I will change to "void __iomem *" for consistency
in the next iteration.
/Axel
next prev parent reply other threads:[~2025-04-08 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:25 [PATCH 0/3] can: kvaser_pciefd: Fix ISR race conditions Axel Forsman
2025-03-31 7:25 ` [PATCH 1/3] can: kvaser_pciefd: Force IRQ edge in case of nested IRQ Axel Forsman
2025-04-07 14:34 ` Marc Kleine-Budde
2025-04-08 12:24 ` Axel Forsman [this message]
2025-03-31 7:25 ` [PATCH 2/3] can: kvaser_pciefd: Fix echo_skb race conditions Axel Forsman
2025-04-07 15:04 ` Marc Kleine-Budde
2025-04-09 10:09 ` Axel Forsman
2025-03-31 7:25 ` [PATCH 3/3] can: kvaser_pciefd: Continue parsing DMA buf after dropped RX Axel Forsman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pu296zb.fsf@kvaser.com \
--to=axfo@kvaser.com \
--cc=extja@kvaser.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.