From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
hreitz@redhat.com, kwolf@redhat.com, eblake@redhat.com,
jsnow@redhat.com, devel@lists.libvirt.org, pkrempa@redhat.com,
michael.roth@amd.com, pbonzini@redhat.com
Subject: Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs
Date: Tue, 08 Apr 2025 11:30:29 +0200 [thread overview]
Message-ID: <871pu3m24q.fsf@pond.sub.org> (raw)
In-Reply-To: <20250404193154.707145-3-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 4 Apr 2025 22:31:54 +0300")
Typo in subject, make it "deprecate".
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> For change, pause, resume, complete, dismiss and finalize actions
> corresponding job- and block-job commands are almost equal. The
> difference is in find_block_job_locked() vs find_job_locked()
> functions. What's different?
>
> 1. find_block_job_locked() do check, is found job a block-job. This OK
> when moving to more generic API, no needs to document this change.
>
> 2. find_block_job_locked() reports DeviceNotActive on failure, when
> find_job_locked() reports GenericError. So, lets document this
> difference in deprecated.txt. Still, for dismiss and finalize errors
> are not documented at all, so be silent in deprecated.txt as well.
>
> ACKed-by: Peter Krempa <pkrempa@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2025-04-08 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 19:31 [PATCH v2 0/2] derpecate some block-job- APIs Vladimir Sementsov-Ogievskiy
2025-04-04 19:31 ` [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation Vladimir Sementsov-Ogievskiy
2025-04-07 15:28 ` Eric Blake
2025-04-07 16:10 ` Vladimir Sementsov-Ogievskiy
2025-04-08 9:27 ` Markus Armbruster
2025-04-04 19:31 ` [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs Vladimir Sementsov-Ogievskiy
2025-04-07 15:21 ` Eric Blake
2025-04-08 9:30 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pu3m24q.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.