Re: [PATCH v3] Support static-only builds

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]

Daniel Burgener <dburgener@linux.microsoft.com> writes:

> On 2/12/2025 10:11 AM, Daniel Burgener wrote:
>> On 2/12/2025 4:16 AM, Alyssa Ross wrote:
>>> Daniel Burgener <dburgener@linux.microsoft.com> writes:
>>>
>>>> On 2/11/2025 4:16 PM, Alyssa Ross wrote:
>>>>> diff --git a/policycoreutils/Makefile b/policycoreutils/Makefile
>>>>> index 32ad0201..7acd51dd 100644
>>>>> --- a/policycoreutils/Makefile
>>>>> +++ b/policycoreutils/Makefile
>>>>> @@ -1,5 +1,10 @@
>>>>>    SUBDIRS = setfiles load_policy newrole run_init secon sestatus 
>>>>> semodule setsebool scripts po man hll unsetfiles
>>>>> +PKG_CONFIG ?= pkg-config
>>>>> +
>>>>> +LIBSELINUX_LDLIBS := $(shell $(PKG_CONFIG) --libs libselinux)
>>>>> +export LIBSELINUX_LDLIBS
>>>>> +
>>>>
>>>> I think that in the DISABLE_SHARED case, the pkg-config command needs
>>>> --static as well.  I tried your patch, and I get errors that the
>>>> downstream users of libselinux have undefined references to libpcre2,
>>>> and they are being build without -lpcre2-8.  Based on the pkg-config man
>>>> page, it looks like Requires.private libraries are only included if the
>>>> --static flag is passed.
>>>
>>> I think it's generally expected that the user set
>>> PKG_CONFIG="pkg-config --static" when they want static linking.  See
>>> e.g. <https://bugs.freedesktop.org/show_bug.cgi?id=19541#c3>.
>> 
>> Thanks for clarifying.  Yes, this command builds everything for me:
>> 
>> make DESTDIR=~/obj PKG_CONFIG="pkg-config --static" DISABLE_SHARED=y 
>> install
>> 
>> However, the binaries still appear dynamically linked when I investigate 
>> them with the "file" command.  Am I missing some other step?
>
> It occurs to me that I've possibly misunderstood the point of your 
> patch.  This is just about not building the shared libraries, 
> independent of whether the binaries are statically linked?

Yes.  The purpose of this is to make it possible to build using a
compiler that only supports static linking.  In Nixpkgs, we have a
special mode where a package and all its dependencies can be built
statically, and my intention here is to be able to build packages that
depend on libselinux in that mode.

Would it maybe make more sense if I split this patch up, so one patch
just makes it possible to disable building shared libraries, and another
fixes building using only static libraries?  Originally this patch was
only the former, but then it grew…

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]