From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A03C02180 for ; Wed, 15 Jan 2025 19:22:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1D1D10E7BE; Wed, 15 Jan 2025 19:22:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="Ip1BlMl9"; dkim-atps=neutral Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE8EA10E7BE for ; Wed, 15 Jan 2025 19:22:53 +0000 (UTC) Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 942CBC0A90 for ; Wed, 15 Jan 2025 19:22:50 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 72E1720003; Wed, 15 Jan 2025 19:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736968947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvlL0mfj44cUCiwG8WLJrEnhaM51ApZOW7dKY/vuFiA=; b=Ip1BlMl93pKCALrSZKHRK3E2cThEoM684DtxClKerUnAHE+XALAA4E2QB0oMKrk/srchnw SJACqMQ8SlerS5Kd+G3O5/P45LVKnwrNDo1y0dGnMb+LEMnqepEj9cNaqlHat/BXjDU/tP wDExJThqs0CvG1AoQXpOb0CDhjX+RyXeoAEFcHqL7xUtC5Bh/X1rfPZ3SqnXmD9BC9Ah6r ap8ZH1MoMHQXnwlAB0GScmJZaG66htE4tpUppAUx/nrlA022aIhLqJPRxwrBodwjIzaiKC 72MBi2xsYuISHHTtsIMZSsPNPbyG7C+vTGixVFj08ptr7fvShIjyoRcooioWfg== From: Miquel Raynal To: "Usyskin, Alexander" Cc: Richard Weinberger , Vignesh Raghavendra , "De Marchi, Lucas" , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , "Vivi, Rodrigo" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , "Poosa, Karthik" , "Abliyev, Reuven" , "Weil, Oren jer" , "linux-mtd@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 01/11] mtd: core: always create master device In-Reply-To: (Alexander Usyskin's message of "Tue, 14 Jan 2025 14:05:40 +0000") References: <20250101153925.865703-1-alexander.usyskin@intel.com> <20250101153925.865703-2-alexander.usyskin@intel.com> <87sepwp6d9.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 15 Jan 2025 20:22:25 +0100 Message-ID: <871px3lw5q.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 14/01/2025 at 14:05:40 GMT, "Usyskin, Alexander" wrote: >> > > Create master device without partition when >> > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. >> > >> > I don't think you took into consideration my remarks regarding the fact >> > that you would break userspace. If you enable the master, you no longer >> > have the same device numbering in userspace. I know people should not >> > care about these numbers, but in practice they do. >> > >> > If I'm wrong, please be a little more verbose about why :) >> > >> > Thanks, >> > Miqu=C3=A8l >>=20 >> Hi Miquel >>=20 >> I've created separate class (mtd_master) for such devices. >> Uses-space looking for mtd device continues to receive same number of >> /dev/mtdX devices. >> There will be additional /dev/mtd_masterX devices, but this is unavoidab= le, I >> suppose. >> Maybe we can rename it to something that not in /dev/mtd* expression (e.= g. >> mastermtdX), >> if it helps. >>=20 > > Miquel, is this good enough or requires rewrite? This is an important change that requires attention, and at the time I have not been able to dedicate enough to this patch. Also, if the other mtd maintainers want to help, I'll be enthousiastic about it :) Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 891B3C02180 for ; Wed, 15 Jan 2025 19:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jUzY1qJiXGth2V4SYDXavLBKrLPgDJI5l+YJCSkKy/U=; b=Rutw0xabdq5dVH SUw4jAb6AA0NWE8/jaItgbVIHPWMHkZahmHLkvOX3npytkvCebrNcFIfs+Z2zmoq7GntlAVH93jDx OHqc6bFK8h0KZDPD9Z5777td7qqNniFeVmkPlvVSN3Eif+2wB3PFFrvEBr453GgQTVFIXee/tj6wL NztGy3Xb4G+n4imyA8Kjxcb3NxQ7QDnDunVfamTR3DgjgsYyA6uxPPPaRuauGOPRTJvULLKn7Cqpu v5Dh8NOuJ/OLxIMtueATJ2kFiGXdmJN/bpMNnFMToImKuM6ADGpYv2ZdjPQf2aM9obgqtEaJfswPf 0pRN/aq2dzuSzyOiGgkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tY8yF-0000000Ctal-40PR; Wed, 15 Jan 2025 19:22:31 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tY8yD-0000000CtaC-1lrf for linux-mtd@lists.infradead.org; Wed, 15 Jan 2025 19:22:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 72E1720003; Wed, 15 Jan 2025 19:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736968947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvlL0mfj44cUCiwG8WLJrEnhaM51ApZOW7dKY/vuFiA=; b=Ip1BlMl93pKCALrSZKHRK3E2cThEoM684DtxClKerUnAHE+XALAA4E2QB0oMKrk/srchnw SJACqMQ8SlerS5Kd+G3O5/P45LVKnwrNDo1y0dGnMb+LEMnqepEj9cNaqlHat/BXjDU/tP wDExJThqs0CvG1AoQXpOb0CDhjX+RyXeoAEFcHqL7xUtC5Bh/X1rfPZ3SqnXmD9BC9Ah6r ap8ZH1MoMHQXnwlAB0GScmJZaG66htE4tpUppAUx/nrlA022aIhLqJPRxwrBodwjIzaiKC 72MBi2xsYuISHHTtsIMZSsPNPbyG7C+vTGixVFj08ptr7fvShIjyoRcooioWfg== From: Miquel Raynal To: "Usyskin, Alexander" Cc: Richard Weinberger , Vignesh Raghavendra , "De Marchi, Lucas" , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , "Vivi, Rodrigo" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , "Poosa, Karthik" , "Abliyev, Reuven" , "Weil, Oren jer" , "linux-mtd@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 01/11] mtd: core: always create master device In-Reply-To: (Alexander Usyskin's message of "Tue, 14 Jan 2025 14:05:40 +0000") References: <20250101153925.865703-1-alexander.usyskin@intel.com> <20250101153925.865703-2-alexander.usyskin@intel.com> <87sepwp6d9.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 15 Jan 2025 20:22:25 +0100 Message-ID: <871px3lw5q.fsf@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250115_112229_754645_52961F48 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGksCgoKT24gMTQvMDEvMjAyNSBhdCAxNDowNTo0MCBHTVQsICJVc3lza2luLCBBbGV4YW5kZXIi IDxhbGV4YW5kZXIudXN5c2tpbkBpbnRlbC5jb20+IHdyb3RlOgoKPj4gPiA+IENyZWF0ZSBtYXN0 ZXIgZGV2aWNlIHdpdGhvdXQgcGFydGl0aW9uIHdoZW4KPj4gPiA+IENPTkZJR19NVERfUEFSVElU SU9ORURfTUFTVEVSIGZsYWcgaXMgdW5zZXQuCj4+ID4KPj4gPiBJIGRvbid0IHRoaW5rIHlvdSB0 b29rIGludG8gY29uc2lkZXJhdGlvbiBteSByZW1hcmtzIHJlZ2FyZGluZyB0aGUgZmFjdAo+PiA+ IHRoYXQgeW91IHdvdWxkIGJyZWFrIHVzZXJzcGFjZS4gSWYgeW91IGVuYWJsZSB0aGUgbWFzdGVy LCB5b3Ugbm8gbG9uZ2VyCj4+ID4gaGF2ZSB0aGUgc2FtZSBkZXZpY2UgbnVtYmVyaW5nIGluIHVz ZXJzcGFjZS4gSSBrbm93IHBlb3BsZSBzaG91bGQgbm90Cj4+ID4gY2FyZSBhYm91dCB0aGVzZSBu dW1iZXJzLCBidXQgaW4gcHJhY3RpY2UgdGhleSBkby4KPj4gPgo+PiA+IElmIEknbSB3cm9uZywg cGxlYXNlIGJlIGEgbGl0dGxlIG1vcmUgdmVyYm9zZSBhYm91dCB3aHkgOikKPj4gPgo+PiA+IFRo YW5rcywKPj4gPiBNaXF1w6hsCj4+IAo+PiBIaSBNaXF1ZWwKPj4gCj4+IEkndmUgY3JlYXRlZCBz ZXBhcmF0ZSBjbGFzcyAobXRkX21hc3RlcikgZm9yIHN1Y2ggZGV2aWNlcy4KPj4gVXNlcy1zcGFj ZSBsb29raW5nIGZvciBtdGQgZGV2aWNlIGNvbnRpbnVlcyB0byByZWNlaXZlIHNhbWUgbnVtYmVy IG9mCj4+IC9kZXYvbXRkWCBkZXZpY2VzLgo+PiBUaGVyZSB3aWxsIGJlIGFkZGl0aW9uYWwgL2Rl di9tdGRfbWFzdGVyWCBkZXZpY2VzLCBidXQgdGhpcyBpcyB1bmF2b2lkYWJsZSwgSQo+PiBzdXBw b3NlLgo+PiBNYXliZSB3ZSBjYW4gcmVuYW1lIGl0IHRvIHNvbWV0aGluZyB0aGF0IG5vdCBpbiAv ZGV2L210ZCogZXhwcmVzc2lvbiAoZS5nLgo+PiBtYXN0ZXJtdGRYKSwKPj4gaWYgaXQgaGVscHMu Cj4+IAo+Cj4gTWlxdWVsLCBpcyB0aGlzIGdvb2QgZW5vdWdoIG9yIHJlcXVpcmVzIHJld3JpdGU/ CgpUaGlzIGlzIGFuIGltcG9ydGFudCBjaGFuZ2UgdGhhdCByZXF1aXJlcyBhdHRlbnRpb24sIGFu ZCBhdCB0aGUgdGltZSBJCmhhdmUgbm90IGJlZW4gYWJsZSB0byBkZWRpY2F0ZSBlbm91Z2ggdG8g dGhpcyBwYXRjaC4KCkFsc28sIGlmIHRoZSBvdGhlciBtdGQgbWFpbnRhaW5lcnMgd2FudCB0byBo ZWxwLCBJJ2xsIGJlIGVudGhvdXNpYXN0aWMKYWJvdXQgaXQgOikKClRoYW5rcywKTWlxdcOobAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K