From: Toon Claes <toon@iotcl.com>
To: karthik nayak <karthik.188@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH v2] reftable/writer: ensure valid range for log's update_index
Date: Wed, 11 Dec 2024 14:10:57 +0100 [thread overview]
Message-ID: <871pyejrfi.fsf@iotcl.com> (raw)
In-Reply-To: <CAOLa=ZRYDqhAPMiuAS-HGaC1huiUGgLW3hL_dDNwrFA5c8ewEQ@mail.gmail.com>
karthik nayak <karthik.188@gmail.com> writes:
> I was reading the reftable code and noticed it. So mostly luck. Agreed
> with what you're saying, I'd say this is mostly a 'safeguard'.
I was wondering as well, thanks for that info.
> Totally, these kind of specific changes are perfect for unit-tests. Plus
> it was very simple to add one too.
I appreciate you're doing this, that makes it easier to reason about
these changes.
>> Will queue. Thanks.
Junio, thank you for the quick turnarond on this patch. For what it's
worth, I've given this a review and I approve these changes.
--
Toon
prev parent reply other threads:[~2024-12-11 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 15:49 [PATCH] reftable/writer: ensure valid range for log's update_index Karthik Nayak
2024-12-06 9:06 ` Patrick Steinhardt
2024-12-06 11:24 ` karthik nayak
2024-12-06 13:13 ` [PATCH v2] " Karthik Nayak
2024-12-06 23:11 ` Junio C Hamano
2024-12-07 9:54 ` karthik nayak
2024-12-11 13:10 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pyejrfi.fsf@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.