Re: [Buildroot] [PATCH] support/scripts: fix RPATH fixups

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Commit a87abcf6da65 (Makefile: run PPD and RPATH fixup in host-fialize)
 > (sic) moved the fixups peviously done in prepare-sdk, to host-finalize.

 > This exposed a bug in fix-rpath, when RPATH contains multiple entries,
 > like:  /PPD/host-foo/host/lib:/PPD/host-foo/host/lib/foo

 > In that situation, we want to get rid of /PPD/host-foo and replace it
 > with the finale HOST_DIR, so we mangle the RPATH with a sed expression.

 > However, that sed expression only ever replaces the first match, as it
 > is missing the 'g' option. Thus, the second (and following) parts of
 > RPATH are still referring to the PPD, and thus patchelf does not find it
 > relative to the final HOST_DIR, amd rops it. This eventually lead to a
 > final RPATH set as $ORIGIN/../lib instead of the expected
 > $ORIGIN/../lib:$ORIGIN/../lib/foo

 > This is the case for host-systemd, which installs some of its libraries
 > in $PREFIX/lib/systemd/ and adds an RPATH set appropriately to
 > /PPD/host-systemd/host/lib:/PPD/host-systemd/host/lib/systemd and that
 > gets incorrectly mangled.

 > Fixes: https://gitlab.com/buildroot.org/buildroot/-/issues/39

 > Also fix a typo in the comment just above.

 > Reported-by: José Luis Salvador Rufo @jlsalvador
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot