From: Kalle Valo <kvalo@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: David Lin <yu-hao.lin@nxp.com>,
l.stach@pengutronix.de, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, briannorris@chromium.org,
tsung-hsien.hsieh@nxp.com
Subject: Re: [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode
Date: Wed, 18 Sep 2024 20:57:38 +0300 [thread overview]
Message-ID: <871q1gdeul.fsf@kernel.org> (raw)
In-Reply-To: <ZuFjtc70r6CGbzcW@gaggiata.pivistrello.it> (Francesco Dolcini's message of "Wed, 11 Sep 2024 11:32:37 +0200")
Francesco Dolcini <francesco@dolcini.it> writes:
> +Lucas (in case he missed this patch)
>
> On Fri, Aug 30, 2024 at 04:07:19PM +0800, David Lin wrote:
>> Firmware crashes when AP works on a DFS channel and radar detection occurs.
>> This patch fixes the issue, also add "fake_radar_detect" entry to mimic
>> radar detection for testing purpose.
>
> Do we want such kind of "fake" code in the driver?
BTW in ath11k we have dfs_simulate_radar debugfs file for testing DFS, I
assume this is something similar. So there are benefits from having it.
> I do not agree that we mix an actual bug fix with additional testing code,
> and if I understand correctly the commit message this is what we are doing
> here.
Yeah, we have a rule "one logical change per patch". So the debugfs
addition needs to be in a separate patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-18 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:07 [PATCH] wifi: mwifiex: fix firmware crash for AP DFS mode David Lin
2024-08-30 8:11 ` Francesco Dolcini
2024-08-30 8:25 ` [EXT] " David Lin
2024-08-30 8:12 ` Francesco Dolcini
2024-09-11 9:32 ` Francesco Dolcini
2024-09-12 2:22 ` [EXT] " David Lin
2024-09-12 7:55 ` Francesco Dolcini
2024-09-13 2:01 ` David Lin
2024-09-18 17:57 ` Kalle Valo [this message]
2024-09-19 1:47 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q1gdeul.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.