From: Michael Ellerman <mpe@ellerman.id.au>
To: Abhishek Dubey <adubey@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, mhiramat@kernel.org
Cc: naveen@kernel.org, hbathini@linux.ibm.com, npiggin@gmail.com,
bpf@vger.kernel.org, Abhishek Dubey <adubey@linux.ibm.com>
Subject: Re: [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc
Date: Tue, 03 Sep 2024 16:48:10 +1000 [thread overview]
Message-ID: <871q216xn9.fsf@mail.lhotse> (raw)
In-Reply-To: <20240830113131.7597-1-adubey@linux.ibm.com>
Abhishek Dubey <adubey@linux.ibm.com> writes:
> This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes:
> Replace kretprobe with rethook on x86") to powerpc.
>
> Rethook follows the existing kretprobe implementation, but separates
> it from kprobes so that it can be used by fprobe (ftrace-based
> function entry/exit probes). As such, this patch also enables fprobe
> to work on powerpc. The only other change compared to the existing
> kretprobe implementation is doing the return address fixup in
> arch_rethook_fixup_return().
>
> Reference to other archs:
> commit b57c2f124098 ("riscv: add riscv rethook implementation")
> commit 7b0a096436c2 ("LoongArch: Replace kretprobe with rethook")
>
> Note:
> =====
>
> In future, rethook will be only for kretprobe, and kretprobe
> will be replaced by fprobe.
>
> https://lore.kernel.org/all/172000134410.63468.13742222887213469474.stgit@devnote2/
>
> We will adapt the above implementation for powerpc once its upstream.
> Until then, we can have this implementation of rethook to serve
> current kretprobe usecases.
>
> Reviewed-by: Naveen Rao <naveen@kernel.org>
> Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
> ---
Was Masami's objection to v3 resolved?
cheers
next prev parent reply other threads:[~2024-09-03 6:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 11:31 [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc Abhishek Dubey
2024-09-03 6:48 ` Michael Ellerman [this message]
2024-09-06 11:52 ` Michael Ellerman
2024-09-08 13:10 ` Masami Hiramatsu
2024-09-09 1:13 ` Andrii Nakryiko
2024-09-09 6:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q216xn9.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=adubey@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=hbathini@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.