All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <me@pmachata.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>,
	Hangbin Liu <liuhangbin@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Petr Machata <petrm@nvidia.com>
Subject: Re: [TEST] forwarding/router_bridge_lag.sh started to flake on Monday
Date: Sun, 25 Aug 2024 11:01:26 +0200	[thread overview]
Message-ID: <871q2d9d74.fsf@nvidia.com> (raw)
In-Reply-To: <20240824142721.416b2bd0@kernel.org>


Jakub Kicinski <kuba@kernel.org> writes:

> On Fri, 23 Aug 2024 18:13:01 +0200 Petr Machata wrote:
>> >> +	ip link set dev $swp2 down
>> >> +	ip link set dev $swp1 down
>> >> +
>> >>  	h2_destroy
>> >>  	h1_destroy
>> >>    
>> >
>> > no_forwarding always runs in thread 0 because it's the slowest tests
>> > and we try to run from the slowest as a basic bin packing heuristic.
>> > Clicking thru the failures I don't see them on thread 0.  
>> 
>> Is there a way to see what ran before?
>
> The data is with the outputs in the "info" file, not in the DB :(
> I hacked up a bash script to fetch those:
> https://github.com/linux-netdev/nipa/blob/main/contest/cithreadmap

Nice.

> Looks like for the failed cases local_termination.sh always runs 
> before router-bridge, and whatever runs next flakes:
>
> Thread4-VM0
> 	 5-local-termination-sh/
> 	 20-router-bridge-lag-sh/
> 	 20-router-bridge-lag-sh-retry/
>
> Thread4-VM0
> 	 5-local-termination-sh/
> 	 16-router-bridge-1d-lag-sh/
> 	 16-router-bridge-1d-lag-sh-retry/

Looks like a no_forwarding cut'n'paste issue. I'll send a fix on Monday.

      reply	other threads:[~2024-08-25  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22 15:37 [TEST] forwarding/router_bridge_lag.sh started to flake on Monday Jakub Kicinski
2024-08-23 11:28 ` Petr Machata
2024-08-23 15:02   ` Jakub Kicinski
2024-08-23 16:13     ` Petr Machata
2024-08-24 21:27       ` Jakub Kicinski
2024-08-25  9:01         ` Petr Machata [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q2d9d74.fsf@nvidia.com \
    --to=me@pmachata.org \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.