From: Takashi Iwai <tiwai@suse.de>
To: Gergo Koteles <soyer@irl.hu>
Cc: Rauty <rautyrauty@gmail.com>,
alsa-devel@alsa-project.org, tiwai@suse.com, perex@perex.cz,
kailang@realtek.com, sbinding@opensource.cirrus.com,
luke@ljones.dev, shenghao-ding@ti.com,
simont@opensource.cirrus.com, foss@athaariq.my.id,
rf@opensource.cirrus.com, wzhd@ustc.edu,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM
Date: Tue, 25 Jun 2024 15:37:06 +0200 [thread overview]
Message-ID: <871q4lm9dp.wl-tiwai@suse.de> (raw)
In-Reply-To: <c0a9e15e7926e098bdea97a7d31c32427e0910c9.camel@irl.hu>
On Tue, 25 Jun 2024 15:32:16 +0200,
Gergo Koteles wrote:
>
> Hey Rauty,
>
> On Mon, 2024-06-24 at 11:25 +0300, Rauty wrote:
> > I haven't changed the patch yet, but it's already in the stable-queue:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.10/alsa-hda-realtek-enable-headset-mic-on-ideapad-330-1.patch
> > Do you still need changes from me?
>
> I still think this breaks Duet 7 sound, because snd_hda_pick_fixup
> function picks the PCI SSIDs before Codec SSIDs.
> But maybe I missed something.
>
> Takashi, what do you think?
Hm, a breakage looks possible, indeed. I naively thought it being a
same model, but this is a different one.
We need an additional codec vendor or SSID check as done for other
machines.
Takashi
next prev parent reply other threads:[~2024-06-25 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 12:54 [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM Ajrat Makhmutov
2024-06-16 7:38 ` Takashi Iwai
2024-06-16 18:07 ` Gergo Koteles
2024-06-18 12:39 ` Rauty
2024-06-24 8:25 ` Rauty
2024-06-25 13:32 ` Gergo Koteles
2024-06-25 13:37 ` Takashi Iwai [this message]
2024-06-25 14:00 ` Rauty
2024-06-25 14:07 ` Takashi Iwai
2024-06-25 14:12 ` Takashi Iwai
2024-06-25 14:16 ` Rauty
2024-06-25 14:26 ` Takashi Iwai
2024-06-25 14:47 ` Rauty
2024-06-25 15:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q4lm9dp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=foss@athaariq.my.id \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=perex@perex.cz \
--cc=rautyrauty@gmail.com \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=shenghao-ding@ti.com \
--cc=simont@opensource.cirrus.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.com \
--cc=wzhd@ustc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.