All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Aivaz <reichaivaz@gmail.com>
Cc: tiwai@suse.com, Aivaz Latypov <pngdrift@mail.ru>,
	kailang@realtek.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx
Date: Mon, 24 Jun 2024 16:10:40 +0200	[thread overview]
Message-ID: <871q4mph27.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAGRy+7AqPTOC5AqWsD4YsoeNTcWTR=OgpVXepBSqBxAq2pxhGg@mail.gmail.com>

On Mon, 24 Jun 2024 10:55:04 +0200,
Aivaz wrote:
> 
> 
> I'm sorry, but I didn't look at my vendor and device id correctly. Here's the
> right one:

Please resubmit as v2 patch.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f4454abadc8d..51225c5770ea 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] =
> {
>         SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> +       SND_PCI_QUIRK(0x103с, 0x87d3, "HP Laptop 15-gw0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>         SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>         SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> 
> On Sun, 23 Jun 2024 at 16:25, Aivaz Latypov <reichaivaz@gmail.com> wrote:
> 
>     This HP Laptop uses ALC236 codec with COEF 0x07 controlling
>     the mute LED. Enable existing quirk for this device.
>    
>     Signed-off-by: Aivaz Latypov <reichaivaz@gmail.com>
>     ---
>      sound/pci/hda/patch_realtek.c | 1 +
>      1 file changed, 1 insertion(+)
>    
>     diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>     index f4454abadc8d..51225c5770ea 100644
>     --- a/sound/pci/hda/patch_realtek.c
>     +++ b/sound/pci/hda/patch_realtek.c
>     @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl
>     [] = {
>             SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>             SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>             SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>     +       SND_PCI_QUIRK(0x10ec, 0x0236, "HP Laptop 15-gw0xxx",
>     ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>             SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
>     ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>             SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
>             SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
>     ALC236_FIXUP_HP_GPIO_LED),
>     --
>     2.45.2
> 

  parent reply	other threads:[~2024-06-24 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23 11:25 [PATCH] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx Aivaz Latypov
     [not found] ` <CAGRy+7AqPTOC5AqWsD4YsoeNTcWTR=OgpVXepBSqBxAq2pxhGg@mail.gmail.com>
2024-06-24 14:10   ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-06-24 10:52 Aivaz Latypov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q4mph27.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kailang@realtek.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=pngdrift@mail.ru \
    --cc=reichaivaz@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.