From: Thomas Gleixner <tglx@linutronix.de>
To: gaosong <gaosong@loongson.cn>, linux-kernel@vger.kernel.org
Cc: chenhuacai@kernel.org, jiaxun.yang@flygoat.com, maobibo@loongson.cn
Subject: Re: [PATCH] irqchip/loongson-eiointc: Add extioi virt extension support
Date: Thu, 06 Jun 2024 16:25:11 +0200 [thread overview]
Message-ID: <871q5a2lo8.ffs@tglx> (raw)
In-Reply-To: <d5efc13a-f719-bc77-1adb-feb73a8155b4@loongson.cn>
Song!
On Thu, Jun 06 2024 at 20:58, gaosong wrote:
> 在 2024/6/6 上午1:36, Thomas Gleixner 写道:
>> On Wed, Jun 05 2024 at 15:02, Song Gao wrote:
>>> int index = eiointc_index(node);
>>> + int cores = (cpu_has_hypervisor ? MAX_CORES_PER_EIO_NODE : CORES_PER_EIO_NODE);
>> Sigh. Please use the documented ordering of variable declaration
>> ordering.
>
> Sorry, I didn't find the information in document [1].
>
> [1]: https://www.kernel.org/doc/html/next/process/coding-style.html
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#coding-style-notes
Thanks,
tglx
prev parent reply other threads:[~2024-06-06 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 7:02 [PATCH] irqchip/loongson-eiointc: Add extioi virt extension support Song Gao
2024-06-05 17:36 ` Thomas Gleixner
2024-06-06 12:58 ` gaosong
2024-06-06 14:25 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q5a2lo8.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@kernel.org \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maobibo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.