Re: [PATCH] abootimg: Add init_boot image support

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Roman,

On jeu., mai 23, 2024 at 00:35, Roman Stratiienko <r.stratiienko@gmail.com> wrote:

[...]

>> >
>> >  static struct cmd_tbl cmd_abootimg_sub[] = {
>> > -     U_BOOT_CMD_MKENT(addr, 3, 1, do_abootimg_addr, "", ""),
>> > +     U_BOOT_CMD_MKENT(addr, 4, 1, do_abootimg_addr, "", ""),
>> >       U_BOOT_CMD_MKENT(dump, 2, 1, do_abootimg_dump, "", ""),
>> >       U_BOOT_CMD_MKENT(get, 5, 1, do_abootimg_get, "", ""),
>> >       U_BOOT_CMD_MKENT(load, 5, 1, do_abootimg_load, "", ""),
>> > @@ -375,7 +391,7 @@ static int do_abootimg(struct cmd_tbl *cmdtp, int flag, int argc,
>> >  U_BOOT_CMD(
>> >       abootimg, CONFIG_SYS_MAXARGS, 0, do_abootimg,
>> >       "manipulate Android Boot Image",
>> > -     "addr <boot_img_addr> [<vendor_boot_img_addr>]>\n"
>> > +     "addr <boot_img_addr> [<vendor_boot_img_addr> [<init_boot_img_addr>]]\n"
>> >       "    - set the address in RAM where boot image is located\n"
>> >       "      ($loadaddr is used by default)\n"
>>
>> Please include the help text update in the documentation:
>> doc/android/boot-image.rst
>
> That documentation does not mention 'abootimg addr' command at the moment.
> I do not see an easy way to add it in a way that makes sense.
>

I see. I will send a documentation update later then.

>>
>> >       "abootimg dump dtb\n"
>> > diff --git a/include/image.h b/include/image.h
>> > index be3c73a72e..b1fd6b3149 100644

[...]