From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B47D1C4345F for ; Thu, 2 May 2024 10:43:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EAA410F19C; Thu, 2 May 2024 10:43:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VdKTPNOb"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EBD210F19C for ; Thu, 2 May 2024 10:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714646632; x=1746182632; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=3sZBRIgqoROawobAb6i4/vhs49OYQKgDcjHFlvkOueg=; b=VdKTPNOb5nwb/Z/+23yj81h8Vjerkkoie+Jyl9OWspAFnCEkPP5YHT93 eddpb5KDkqd+yS4J7OxDd9mrnmBeivAgY2Ki+2Xur157d4FCNDU99z8W0 r5RsPDNONYs/zNdZcbvm1K0//xknfDhLNUbyO9TNUF4+QbkQPoJeo+zs2 ddEz321hkre5Ux67Cx9I6JzKXQEGILugeYSC9tWsLfnRLOjw7Xqlp43AU PDctUL7Qhllfkn8jezDbdSyExBa106N6mYoRl7Tj0TYVFQm5XOdcUSKPb VpN4M+KggUZvaRgkESQosa0D+xK6lE1lAVJAuOJZeBZ/yN9wW6C12lp8+ A==; X-CSE-ConnectionGUID: RIp266asT/e0zjuuRAPv7A== X-CSE-MsgGUID: w34N1YY4QIeD9YOb1GUVOQ== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="21811527" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="21811527" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 03:43:51 -0700 X-CSE-ConnectionGUID: 5GHbjvfdS1aKfKGpKTSbmQ== X-CSE-MsgGUID: PGXG0UIRR1aswUwRmq7oZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="58280905" Received: from unknown (HELO localhost) ([10.245.245.19]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 03:43:49 -0700 From: Jani Nikula To: Suraj Kandpal , intel-gfx@lists.freedesktop.org Cc: uma.shankar@intel.com, ankit.k.nautiyal@intel.com, Suraj Kandpal Subject: Re: [PATCH 1/2] drm/i915/hdcp: Move aux assignment after connector type check In-Reply-To: <20240430064030.887080-2-suraj.kandpal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240430064030.887080-1-suraj.kandpal@intel.com> <20240430064030.887080-2-suraj.kandpal@intel.com> Date: Thu, 02 May 2024 13:43:47 +0300 Message-ID: <871q6kpk7w.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 30 Apr 2024, Suraj Kandpal wrote: > Move assignment of aux after connector type check as port may not > exist if connector is not DPMST. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index 92b03073acdd..92be53d7c81f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -687,15 +687,16 @@ int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector, > bool *hdcp2_capable) > { > struct drm_i915_private *i915 = to_i915(connector->base.dev); > - struct drm_dp_aux *aux = &connector->port->aux; > + struct drm_dp_aux *aux; > u8 bcaps; > int ret; > > *hdcp_capable = false; > *hdcp2_capable = false; > - if (!intel_encoder_is_mst(connector->encoder)) > + if (intel_encoder_is_mst(connector->encoder)) Suspicious. > return -EINVAL; > > + aux = &connector->port->aux; > ret = _intel_dp_hdcp2_get_capability(aux, hdcp2_capable); > if (ret) > drm_dbg_kms(&i915->drm, -- Jani Nikula, Intel