From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C83DCD11C2 for ; Fri, 5 Apr 2024 12:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lD0XRFuPE5wP0/CUQtsdXKQt8B+kLkYtSG6lX6qY/pQ=; b=Vd0nKyce3vUxbunM/kN1S+dFJX 6plRIz3xgiYTwsaUAMD6PokdD7jq7VsjaVr3ZHaZZBLE6IDKGJ4an1OUcYBmx3GScihDE1V0iR4p0 4Ir1snAabaV110T4/p7vu5pGPFa1PrMfUMEW8cXB+YLrolVx3SF00LwFNrUL3cW1bsmZ3Ow0dw8f2 OEsqsnUyf9kkzoeexvMDaAEbgeihRj7qLj71H0lrAjrg0DUAXZkjIi2MPYY0YLRHlQ1bamVRoFajA 52lHoogcQym+eZptG3DEtcZ40G+khVgQYXWtqz4XCXG7BzrhdF7t2RZJB9h3PqWxVuEtExVTODNhO A5WK2Kpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsiGR-00000006neD-42Uj; Fri, 05 Apr 2024 12:01:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsiGF-00000006nal-3b6c for ath10k@lists.infradead.org; Fri, 05 Apr 2024 12:01:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7D25761788; Fri, 5 Apr 2024 12:01:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDA8EC433F1; Fri, 5 Apr 2024 12:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712318494; bh=QfTxdUZ4pDgKliLEER39neqecZfbyAbJ7BTYOdpacGc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iyyFBcSD6m7ogc+YN8nQm4I7X3V3LJ3Z8Cj1jZfPA5pcFRZ0S7cHwyHl5oHubDP2y gj8TOTmSmxmEx9q9ssDnP0jeX09zetYRhWKXCU+do2APq3xH0ixAXuLRLikKdiU+LN 39dPXYDdmNIPp5obkXwG1FQoxasd+NDdzRI2gV51KhnaOU/vB8DPlvIpGy68k8BTss cnYS+SOZs1p9pMvexdOeFsKjyBBygHNTv1fwnTov7lmQDSHoZOAA+1Z2HIoUyNrtUN FJZJWplHpSGGy8loofeW64+QAkKfqGue72ECVf7Z/128+ViA2LHUTI/QkH9FAx3ZkR 15ndyIAvKOj5A== From: Kalle Valo To: Dmitry Baryshkov Cc: Jeff Johnson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides References: <20240306-wcn3990-firmware-path-v2-0-f89e98e71a57@linaro.org> <87plw7hgt4.fsf@kernel.org> <87cys7hard.fsf@kernel.org> <87v85wg39y.fsf@kernel.org> Date: Fri, 05 Apr 2024 15:01:29 +0300 In-Reply-To: (Dmitry Baryshkov's message of "Sat, 9 Mar 2024 17:07:46 +0200") Message-ID: <871q7k3tnq.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_050136_052334_8EA7BA83 X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Dmitry Baryshkov writes: > On Fri, 8 Mar 2024 at 17:19, Kalle Valo wrote: >> >> Dmitry Baryshkov writes: >> >> >> To be on the safe side using 'qcom-rb1' makes sense but on the other >> >> hand that means we need to update linux-firmware (basically add a new >> >> symlink) everytime a new product is added. But are there going to be >> >> that many new ath10k based products? >> >> >> >> Using 'qcm2290' is easier because for a new product then there only >> >> needs to be a change in DTS and no need to change anything >> >> linux-firmware. But here the risk is that if there's actually two >> >> different ath10k firmware branches for 'qcm2290'. If that ever happens >> >> (I hope not) I guess we could solve that by adding new 'qcm2290-foo' >> >> directory? >> >> >> >> But I don't really know, thoughts? >> > >> > After some thought, I'd suggest to follow approach taken by the rest >> > of qcom firmware: >> >> Can you provide pointers to those cases? > > https://gitlab.com/kernel-firmware/linux-firmware/-/tree/main/qcom/sc8280xp/LENOVO/21BX > >> >> > put a default (accepted by non-secured hardware) firmware to SoC dir >> > and then put a vendor-specific firmware into subdir. If any of such >> > vendors appear, we might even implement structural fallback: first >> > look into sdm845/Google/blueline, then in sdm845/Google, sdm845/ and >> > finally just under hw1.0. >> >> Honestly that looks quite compilicated compared to having just one >> sub-directory. How will ath10k find the directory names (or I vendor and >> model names) like 'Google' or 'blueline' in this example? > > I was thinking about the firmware-name = "sdm845/Google/blueline". But > this can be really simpler, firmware-name = "blueline" or > "sdm845/blueline" with no need for fallbacks. I have been also thinking about this and I would prefer not to have the fallbacks. But good if you agree with that. IMHO just "sdm845-blueline" would be the most simple. I don't see the point of having a directory structure when there are not that many directories really. But this is just cosmetics. > My point is that the firmware-name provides the possibility to handle > that in different ways. Very good, thanks. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches