From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
P Praneesh <quic_ppranees@quicinc.com>
Subject: Re: [PATCH 1/2] wifi: ath12k: fix BSS chan info request WMI command
Date: Tue, 02 Apr 2024 14:46:03 +0300 [thread overview]
Message-ID: <871q7o6l8k.fsf@kernel.org> (raw)
In-Reply-To: <20240331183232.2158756-2-quic_kathirve@quicinc.com> (Karthikeyan Kathirvel's message of "Mon, 1 Apr 2024 00:02:31 +0530")
Karthikeyan Kathirvel <quic_kathirve@quicinc.com> writes:
> From: P Praneesh <quic_ppranees@quicinc.com>
>
> Currently, the firmware returns incorrect pdev_id information in
> WMI_PDEV_BSS_CHAN_INFO_EVENTID, leading to incorrect filling of
> the pdev's survey information.
>
> To prevent this issue, when requesting BSS channel information
> through WMI_PDEV_BSS_CHAN_INFO_REQUEST_CMDID, firmware expects
> pdev_id as one of the arguments in this WMI command.
>
> Add pdev_id to the struct wmi_pdev_bss_chan_info_req_cmd and fill it
> during ath12k_wmi_pdev_bss_chan_info_request(). This resolves the
> issue of sending the correct pdev_id in WMI_PDEV_BSS_CHAN_INFO_EVENTID.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
What about backwards compatibility with older firmware? And what about
WCN7850?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-02 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 18:32 [PATCH 0/2] wifi: ath12k: fix BSS chan info request WMI command Karthikeyan Kathirvel
2024-03-31 18:32 ` [PATCH 1/2] " Karthikeyan Kathirvel
2024-04-01 15:00 ` Jeff Johnson
2024-04-01 16:12 ` Jeff Johnson
2024-04-05 12:59 ` Kalle Valo
2024-04-02 11:46 ` Kalle Valo [this message]
2024-08-07 8:12 ` Kalle Valo
2024-03-31 18:32 ` [PATCH 2/2] wifi: ath12k: match WMI BSS chan info structure with firmware definition Karthikeyan Kathirvel
2024-04-01 15:01 ` Jeff Johnson
2024-04-01 16:11 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q7o6l8k.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kathirve@quicinc.com \
--cc=quic_ppranees@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.