From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2,1/1] package/zlib-ng: fix arm build
Date: Sun, 17 Mar 2024 12:22:32 +0100 [thread overview]
Message-ID: <871q89je6f.fsf@48ers.dk> (raw)
In-Reply-To: <20240221181650.1115046-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Wed, 21 Feb 2024 19:16:50 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> zlib-ng usage uses CMAKE_C_COMPILER_TARGET which is non-standard and
> is not supposed to be used by the CMakeLists.txt machinery of a
> particular package.
> Indeed, [1] specifies that:
> Some compiler drivers are inherently cross-compilers, such as clang
> and QNX qcc. These compiler drivers support a command-line argument
> to specify the target to cross-compile for.
> buildroot is not using clang nor QNX qcc.
> [2] also refers to this variable only for clang [3] and QNX [4].
> Therefore, zlib-ng's usage of this variable is a bit of a hack, and it's
> actually why it works when passed as an argument, because they are in
> fact not supposed to use this variable.
> So set CMAKE_C_COMPILER_TARGET to BR2_ARCH to fix the following arm
> build failure raised since bump to version 2.0.6 in commit
> d2249821d3f30202ca2a35ad24918378d9a0a0e8:
> -- Detecting C compile features - done
> -- Arch not recognized, falling back to cmake arch: 'l'
> -- Basearch 'l' not recognized, defaulting to 'x86'.
> -- Basearch of 'l' has been detected as: 'x86'
> [...]
> /home/buildroot/autobuild/instance-0/output-1/build/zlib-ng-2.1.3/arch/x86/x86_features.c:17:12: fatal error: cpuid.h: No such file or directory
> 17 | # include <cpuid.h>
> | ^~~~~~~~~
> [1] https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_TARGET.html
> [2] https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html
> [3] https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-using-clang
> [4] https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-qnx
> Fixes: d2249821d3f30202ca2a35ad24918378d9a0a0e8
> - http://autobuild.buildroot.org/results/1551aa69be19239a8d8e081f033e4027d679ab8f
> - http://autobuild.buildroot.org/results/075d704c0f11710353bac43478e4501addcd747d
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni and Peter Korsgaard):
> - Update commit message
Committed to 2023.02.x and 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-03-17 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 18:16 [Buildroot] [PATCH v2,1/1] package/zlib-ng: fix arm build Fabrice Fontaine
2024-02-21 20:19 ` Yann E. MORIN
2024-03-17 11:22 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q89je6f.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.