From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/5] wifi: ath11k: thermal: don't try to register multiple times
Date: Thu, 22 Feb 2024 08:25:04 +0200 [thread overview]
Message-ID: <871q95audb.fsf@kernel.org> (raw)
In-Reply-To: <5828b835-6b4d-4245-991a-7f6b54ee8b51@quicinc.com> (Baochen Qiang's message of "Thu, 22 Feb 2024 10:34:16 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 2/22/2024 1:15 AM, Jeff Johnson wrote:
>> On 2/20/2024 6:47 PM, Baochen Qiang wrote:
>>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>>
>>> Every time the firmware boots we call ath11k_core_qmi_firmware_ready() which
>>> ends up calling ath11k_thermal_register(). So we try to register thermal
>>> devices multiple times. And when we power off the firmware during
>>> suspend/hibernation (implemented in the next patch) we get a warning in resume:
>>>
>>> hwmon hwmon4: PM: parent phy0 should not be sleeping
>>>
>>> Workaround this similarly like ath11k_mac_register() does by testing
>>> ATH11K_FLAG_REGISTERED.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>>>
>>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>> you need to add your own S-O-B
> Oh, sorry for missing that.
>
> Hi Kalle, I see you have put this series in pending branch. I am
> wondering if I need to send a v2 to add my S-O-B tag, or you have any
> other plan?
I can add it in the pending branch if you send it to me as a reply to
this mail. s-o-b is like a signature so I won't add it on my own.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-22 6:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 2:47 [PATCH 0/5] wifi: ath11k: prepare for hibernation support Baochen Qiang
2024-02-21 2:47 ` [PATCH 1/5] wifi: ath11k: rearrange IRQ enable/disable in reset path Baochen Qiang
2024-02-21 17:13 ` Jeff Johnson
2024-02-23 15:52 ` Kalle Valo
2024-02-21 2:47 ` [PATCH 2/5] wifi: ath11k: remove MHI LOOPBACK channels Baochen Qiang
2024-02-21 17:14 ` Jeff Johnson
2024-02-21 2:47 ` [PATCH 3/5] wifi: ath11k: do not dump SRNG statistics during resume Baochen Qiang
2024-02-21 17:14 ` Jeff Johnson
2024-02-21 2:47 ` [PATCH 4/5] wifi: ath11k: fix warning on DMA ring capabilities event Baochen Qiang
2024-02-21 17:14 ` Jeff Johnson
2024-02-21 2:47 ` [PATCH 5/5] wifi: ath11k: thermal: don't try to register multiple times Baochen Qiang
2024-02-21 17:15 ` Jeff Johnson
2024-02-22 2:34 ` Baochen Qiang
2024-02-22 6:25 ` Kalle Valo [this message]
2024-02-22 7:43 ` Baochen Qiang
2024-02-22 14:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q95audb.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.