From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc
Date: Wed, 14 Feb 2024 20:03:48 +0200 [thread overview]
Message-ID: <871q9e7wjf.fsf@intel.com> (raw)
In-Reply-To: <ZczpiYb8aApSTJz3@intel.com>
On Wed, 14 Feb 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Feb 14, 2024 at 03:50:49PM +0200, Jani Nikula wrote:
>> As follow-up, would be great to see this move towards drm_printer based
>> approach, similar to pipe_config_dp_vsc_sdp_mismatch(). Reduces
>> duplication.
>
> Why did we convert just that single thing and not everything?
That change originated from me fixing drm_dp_vsc_sdp_log(), which was
quite horrible, to use drm_printer. So I just changed the drm side of
things, and haven't yet gotten around to fixing other things i915 side.
In fact 2e61504fd1c3 ("drm/dp: switch drm_dp_vsc_sdp_log() to struct
drm_printer") only exists in drm-misc-next, and we'll need that stuff
merged to drm-next and back to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-02-14 18:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 18:38 [PATCH 0/5] drm/i915: PLL state check stuff Ville Syrjala
2024-02-09 18:38 ` [PATCH 1/5] drm/i915: Fix PLL state check for gmch platforms Ville Syrjala
2024-02-12 14:11 ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 2/5] drm/i915: Include the CRTC name in the ELD buffer mismatch Ville Syrjala
2024-02-13 10:34 ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 3/5] drm/i915: Reuse ibx_dump_hw_state() for gmch platforms Ville Syrjala
2024-02-13 12:59 ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc Ville Syrjala
2024-02-13 16:15 ` Kahola, Mika
2024-02-14 23:53 ` Ville Syrjälä
2024-02-14 13:50 ` Jani Nikula
2024-02-14 16:25 ` Ville Syrjälä
2024-02-14 18:03 ` Jani Nikula [this message]
2024-02-09 18:38 ` [PATCH 5/5] drm/i915: Enable fastboot across the board Ville Syrjala
2024-02-14 8:58 ` Kahola, Mika
2024-02-09 19:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff Patchwork
2024-02-09 19:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-09 20:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10 4:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff (rev2) Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-10 13:37 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10 15:02 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q9e7wjf.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.