From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F0E9C48260 for ; Thu, 8 Feb 2024 09:24:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E45910E083; Thu, 8 Feb 2024 09:24:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bj5jiJR/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7277910E083 for ; Thu, 8 Feb 2024 09:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707384284; x=1738920284; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=FB9qOX79JGNQOW/6rGSqIiH+Lg2SkTQWTNqsSa/QyWQ=; b=bj5jiJR/o9W94Hyh3UdrA35PnpMNSCOzxiByJ7OVXxxBVIHNJZo6W+EM lDwp98ZapctsVZN4UBsgv1rDpfX/iSC+Dssswn53jTsqAC41GqJ2VMo3r GkQJu7rDBBxZQMuKDgZdcuSUCDxyLqn3MnhxbpZ230tGhazN/xKmTFCdN zQ+bMJRTd5GdSPQxvijgSN3cp/TbmZZL3Dw67hfizO0q19Ba8gkHQGXLl BFbP3g3ZsifUd6SlH/QR5Q5XdjVcZjMs4BFjSRZJz1H/z3AQe0BpX+dup DeAnRM3/c8xmmpveEPhJ044DUfn1g8w7SmDo0YnKjZPZcWmhY1naHaNPU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="23660475" X-IronPort-AV: E=Sophos;i="6.05,253,1701158400"; d="scan'208";a="23660475" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 01:24:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,253,1701158400"; d="scan'208";a="1626949" Received: from aavzirov-mobl.ger.corp.intel.com (HELO localhost) ([10.252.61.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 01:24:40 -0800 From: Jani Nikula To: Juha-Pekka Heikkila , intel-gfx@lists.freedesktop.org Cc: Juha-Pekka Heikkila , Mika Kahola Subject: Re: [PATCH 1/1] drm/i915/display: On Xe2 always enable decompression with tile4 In-Reply-To: <20240202150602.430036-2-juhapekka.heikkila@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240202150602.430036-1-juhapekka.heikkila@gmail.com> <20240202150602.430036-2-juhapekka.heikkila@gmail.com> Date: Thu, 08 Feb 2024 11:24:35 +0200 Message-ID: <871q9ncnqk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 02 Feb 2024, Juha-Pekka Heikkila wrote: > With Xe2 always treat tile4 as if it was using flat ccs. > > Signed-off-by: Juha-Pekka Heikkila > Reviewed-by: Mika Kahola > --- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c > index 511dc1544854..43209909593f 100644 > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c > @@ -948,6 +948,11 @@ static u32 skl_plane_ctl(const struct intel_crtc_state *crtc_state, > if (DISPLAY_VER(dev_priv) == 13) > plane_ctl |= adlp_plane_ctl_arb_slots(plane_state); > > + if (GRAPHICS_VER(dev_priv) >= 20 && Hmh, I just got rid of *all* GRAPHICS_VER and variants under display/. BR, Jani. > + fb->modifier == I915_FORMAT_MOD_4_TILED) { > + plane_ctl |= PLANE_CTL_RENDER_DECOMPRESSION_ENABLE; > + } > + > return plane_ctl; > } -- Jani Nikula, Intel