All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>, Het Gala <het.gala@nutanix.com>,
	qemu-devel@nongnu.org
Cc: peterx@redhat.com, berrange@redhat.com, armbru@redhat.com,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH] Make 'uri' optional for migrate QAPI
Date: Mon, 29 Jan 2024 17:56:05 -0300	[thread overview]
Message-ID: <871q9zq2oq.fsf@suse.de> (raw)
In-Reply-To: <1023dde3-4de0-4ec1-85a6-238ed8e16454@tls.msk.ru>

Michael Tokarev <mjt@tls.msk.ru> writes:

> 23.01.2024 09:42, Het Gala:
>> 'uri' argument should be optional, as 'uri' and 'channels'
>> arguments are mutally exclusive in nature.
>> 
>> Fixes: 074dbce5fcce (migration: New migrate and
>> migrate-incoming argument 'channels')
>> Signed-off-by: Het Gala <het.gala@nutanix.com>
>> ---
>>   qapi/migration.json | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/qapi/migration.json b/qapi/migration.json
>> index eb2f883513..197d3faa43 100644
>> --- a/qapi/migration.json
>> +++ b/qapi/migration.json
>> @@ -1757,7 +1757,7 @@
>>   #
>>   ##
>>   { 'command': 'migrate',
>> -  'data': {'uri': 'str',
>> +  'data': {'*uri': 'str',
>>              '*channels': [ 'MigrationChannel' ],
>>              '*blk': { 'type': 'bool', 'features': [ 'deprecated' ] },
>>              '*inc': { 'type': 'bool', 'features': [ 'deprecated' ] },
>
> This seems like a stable material too, - please let me know if it is not.
>

Yes, those API changes went into 8.2.

Thanks


  reply	other threads:[~2024-01-29 20:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  6:42 [PATCH] Make 'uri' optional for migrate QAPI Het Gala
2024-01-23  6:47 ` Het Gala
2024-01-23  8:21 ` Daniel P. Berrangé
2024-01-24  1:43   ` Peter Xu
2024-01-24  4:33     ` Het Gala
2024-01-26 14:10       ` Het Gala
2024-01-26 14:30         ` Daniel P. Berrangé
2024-01-29 20:30 ` Michael Tokarev
2024-01-29 20:56   ` Fabiano Rosas [this message]
2024-01-30  1:35   ` Peter Xu
2024-01-30  6:45     ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q9zq2oq.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=het.gala@nutanix.com \
    --cc=mjt@tls.msk.ru \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.