From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94055C47DB3 for ; Mon, 29 Jan 2024 16:55:38 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id D2A2B216A3 for ; Mon, 29 Jan 2024 16:55:37 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C4D1C9868A2 for ; Mon, 29 Jan 2024 16:55:37 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id B58FA986873; Mon, 29 Jan 2024 16:55:37 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id A3631986871 for ; Mon, 29 Jan 2024 16:55:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: JmTaaBZPNh6HjKB-Lun6fA-1 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org In-Reply-To: <20240129112559-mutt-send-email-mst@kernel.org> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <87a5ookwme.fsf@redhat.com> <20240129112559-mutt-send-email-mst@kernel.org> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 29 Jan 2024 17:55:27 +0100 Message-ID: <871qa0krk0.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: [virtio-comment] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing On Mon, Jan 29 2024, "Michael S. Tsirkin" wrote: > On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: >> On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: >> >> > This is not a huge deal since it's a SHOULD anyway, >> > so make the new requirement SHOULD too. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> > device-types/net/description.tex | 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex >> > index aff5e08..d1d25fe 100644 >> > --- a/device-types/net/description.tex >> > +++ b/device-types/net/description.tex >> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi >> > >> > The device MUST ignore \field{reserved}. >> > >> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. >> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and >> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if >> > +it was not able to change coalescing parameters. In this case, >> >> Hm, if we explicitly specify "coalescing parameters" here, should we add >> it below as well? (We probably should keep the "the".) > > maybe "some of the" and in the next sentence "all of the". > > so it's atomic: all or nothing. Makes sense. > >> > +the parameters SHOULD remain unchanged, for all VQs. >> > + >> > >> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters. Also here ^ ? This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 110E8C47DB3 for ; Mon, 29 Jan 2024 16:55:32 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 617EA2CABB for ; Mon, 29 Jan 2024 16:55:32 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 3FF6398687B for ; Mon, 29 Jan 2024 16:55:32 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 260B7983F75; Mon, 29 Jan 2024 16:55:32 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id DF2A6986871 for ; Mon, 29 Jan 2024 16:55:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: JmTaaBZPNh6HjKB-Lun6fA-1 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org In-Reply-To: <20240129112559-mutt-send-email-mst@kernel.org> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <87a5ookwme.fsf@redhat.com> <20240129112559-mutt-send-email-mst@kernel.org> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 29 Jan 2024 17:55:27 +0100 Message-ID: <871qa0krk0.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: [virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing On Mon, Jan 29 2024, "Michael S. Tsirkin" wrote: > On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: >> On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: >> >> > This is not a huge deal since it's a SHOULD anyway, >> > so make the new requirement SHOULD too. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> > device-types/net/description.tex | 6 +++++- >> > 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > diff --git a/device-types/net/description.tex b/device-types/net/description.tex >> > index aff5e08..d1d25fe 100644 >> > --- a/device-types/net/description.tex >> > +++ b/device-types/net/description.tex >> > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi >> > >> > The device MUST ignore \field{reserved}. >> > >> > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. >> > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and >> > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if >> > +it was not able to change coalescing parameters. In this case, >> >> Hm, if we explicitly specify "coalescing parameters" here, should we add >> it below as well? (We probably should keep the "the".) > > maybe "some of the" and in the next sentence "all of the". > > so it's atomic: all or nothing. Makes sense. > >> > +the parameters SHOULD remain unchanged, for all VQs. >> > + >> > >> > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters. Also here ^ ? --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org