From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 398E5C47258 for ; Tue, 23 Jan 2024 19:17:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E43610E86D; Tue, 23 Jan 2024 19:17:22 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 939B610E863 for ; Tue, 23 Jan 2024 19:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706037440; x=1737573440; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=a4D7Gvm3E3IKOqSNk13QoOG/5s/jLnUCyPtJuWQkTL0=; b=QUvSJrOYPKa6aq0JP+UOgj8HhRlHP4nEIrR6V0LVRrfukcH+OnYAoMoK tiH+aJvK/Bins81y0zP98A3tk0U3SDvAgBVuqMtqaCoDBNj2mRbV2/TYq ZSM8uRDrAmFGOZDqLkm2HrU4bsZujtiLaPrYDbPg59VOwb/rd8nG1PyLX l9ia7SQc+u5j2E/meFWX8slyYwwrB1gl8oGHSMWWc+qQKFfHteDyKNN75 wgYq9SykFnnfJsOKTQqIk767SMR4g65iCX1OQYYEF85IK1G/CewKY6QGe auWihyuTmThV+Jq1Om5CCPSOw6pZpp2qRutPfSCIumC9qVrkMQZ508AOQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="15143552" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="15143552" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 11:17:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="929429114" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="929429114" Received: from pzsolt-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.40.183]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 11:17:15 -0800 From: Jani Nikula To: Thomas Zimmermann , javierm@redhat.com, chenhuacai@kernel.org Subject: Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync" In-Reply-To: <874jf4nmgp.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240123120937.27736-1-tzimmermann@suse.de> <874jf4nmgp.fsf@intel.com> Date: Tue, 23 Jan 2024 21:17:13 +0200 Message-ID: <871qa7n9l2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thorsten Leemhuis , Thomas Zimmermann , Jaak Ristioja , Huacai Chen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 23 Jan 2024, Jani Nikula wrote: > On Tue, 23 Jan 2024, Thomas Zimmermann wrote: >> This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4. >> >> Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from >> device_initcall to subsys_initcall_sync") messes up initialization order >> of the graphics drivers and leads to blank displays on some systems. So >> revert the commit. >> >> To make the display drivers fully independent from initialization >> order requires to track framebuffer memory by device and independently >> from the loaded drivers. The kernel currently lacks the infrastructure >> to do so. >> >> Reported-by: Jaak Ristioja >> Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t >> Reported-by: Huacai Chen >> Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/ >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133 > > FWIW, > > Acked-by: Jani Nikula > > but would be great to get a Tested-by from Jaak or from the gitlab issue > reporter. The revert works for the gitlab issue reporter. BR, Jani. -- Jani Nikula, Intel